[asterisk-bugs] [Asterisk 0010297]: [patch] Unload/load support for chan_skinny

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10297 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10297
Category:                   Channels/chan_skinny/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta8 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 76940 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2007-07-25 01:40 CDT
Last Modified:              2008-11-22 20:28 CST
====================================================================== 
Summary:                    [patch] Unload/load support for chan_skinny
Description: 
Reload is not working, but unload and load do work.
My reload code is ugly-simple, it calls the unload 
function, then the load function.  I would have thought
if I could manually unload and load that would be enough.


My threading knowledge is more than a bit weak, but the
existing code was 90% there already.  We needed to store
the address of the skinny_session thread launch from within
accept_thread so we could later cancel it.

Interestingly the skinnysession structure had a member to
store the thread address, but it did not appear to be used.

I also move the teardown of the accept thread to a point before
tearing down the sessions (and their threads) to prevent a phone
from trying to re-register and recreating a session thread after
we had processed it.


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013524 [patch] Fixes skinny unload
====================================================================== 

---------------------------------------------------------------------- 
 (0095334) DEA (reporter) - 2008-11-22 20:28
 http://bugs.digium.com/view.php?id=10297#c95334 
---------------------------------------------------------------------- 
The skinny phones are not too smart, but one thing they do get right
is the reset/soft reset.  The device will queue the reset until after
the phone is idle, so we should not need any special handling of
subs with regards to the reset.  As for subsequent calls, I could
go either way, allow it through or allow the dialplan to handle it
as a busy signal.  I would lean towards allowing it through...

The reason I decided to create new devices/lines instead of reconfiguring
was simple.  The phone needs to be reset for the changes to apply and,
is seemed cleaner to build new lines and devices than to try to merge
the old and new configs.

If we do re-use and existing loaded device, we must remove all lines and
speeddials before attempting to add new ones.  Otherwise devices that
do not change might end up with duplicates. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-22 20:28 DEA            Note Added: 0095334                          
======================================================================