[asterisk-bugs] [LibPRI 0012861]: [patch] TBR4 conformance

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12861 
====================================================================== 
Reported By:                tzafrir
Assigned To:                mattf
====================================================================== 
Project:                    LibPRI
Issue ID:                   12861
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 571 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-06-14 16:31 CDT
Last Modified:              2008-11-21 18:35 CST
====================================================================== 
Summary:                    [patch] TBR4 conformance
Description: 
We needed the following changes in order to pass a TBR4 conformance test.

Several issues we encountered:

1. Handling of received REJ frames is completely incorrect.
2. In some cases the C/R and P/F bits are not set correctly.
3. When the last I-frame retransmission is required the first frame in
the
queue was retransmitted. But if there are several not yet acknowledged
frames
in the queue then such behavior is not correct because the last
transmitted
frame is not at the queue head.
4. N(R) from received RNR was not considered as acknowledge for
outstanding
I-frames.
5. Frames retransmission was performed N200-1 times instead of N200
times.
6. Timers T200 and T203 sometimes were not restarted. (Timer was not
reset
if it was started before).

Traces that demonstrate those issues are included in the attached file 
First-L2test-results.txt .
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012153 [patch] librpi: Data link layer does no...
====================================================================== 

---------------------------------------------------------------------- 
 (0095315) mattf (administrator) - 2008-11-21 18:35
 http://bugs.digium.com/view.php?id=12861#c95315 
---------------------------------------------------------------------- 
Hey guys.  Just merged it in.  Thanks for getting this done, and thanks for
waiting for my time to review it. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-21 18:35 mattf          Note Added: 0095315                          
======================================================================