[asterisk-bugs] [Asterisk 0012475]: [patch] message about number of new and old messages not properly conjugated in Russian

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12475 
====================================================================== 
Reported By:                chappell
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12475
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-04-18 09:35 CDT
Last Modified:              2008-11-21 11:20 CST
====================================================================== 
Summary:                    [patch] message about number of new and old messages
not properly conjugated in Russian
Description: 
This is an old patch which we have been using for over a year.  Without it
the introductory message about how many voicemail messages are in the new
and old boxes is garbled.  The problems include dropt works, bad grammar,
and wrong counts.  As best I remember the patch fixes these problems:

* removed bad exception code for the Russian word for "one" in the neuter
singular
* due to confusion one of the counts of messages was wrong
* fixed conjugation of the adjectives meaning "old" and "new"

If necessary, I can go back and study the old code in order to accurately
describe exactly how it garbles the message.



====================================================================== 

---------------------------------------------------------------------- 
 (0095270) chappell (reporter) - 2008-11-21 11:20
 http://bugs.digium.com/view.php?id=12475#c95270 
---------------------------------------------------------------------- 
I have uploaded vm_multilang.patch and app_say_counted.c.  I believe it
answers all of Corydon76's comments.  The changes are:

1) spacing and bracket use changed to conform to guidelines
2) argument parsing macros are now used
3) applications moved into own source file
4) Changed name from "universal" to "multilang" and enabled for Russian,
Ukrainian, and English to demonstrate that it truly supports multiple
languages. (Though, based on an examination of the code for other
langauges, I believe it can replace _all_ of the vm_intro_* functions, I
enabled it only for languages that I know.)  Added extensive comments
which, among other things, explain why the code to pluralize English nouns
should be considered correct.
5) Replaced static buffers with alloca() buffers.

Enabling this code for a new languages requires these steps:
1) Add a rule to call vm_intro_multilang() from vm_intro().  This rule
should indicate the gender for the word meaning "message"
2) Select the proper delension rule in say.c
3) Rename VM sound files to use standard naming convention (such as
digit/1n rather than digit/odno) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-21 11:20 chappell       Note Added: 0095270                          
======================================================================