[asterisk-bugs] [Asterisk 0013668]: sip show inuse count is negative

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13668 
====================================================================== 
Reported By:                mjc
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13668
Category:                   Channels/chan_sip/General
Reproducibility:            random
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.0 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-10 15:02 CDT
Last Modified:              2008-11-17 17:40 CST
====================================================================== 
Summary:                    sip show inuse count is negative
Description: 
I have a bunch of snom 360s and asterisk-1.6.0-rc6. The snom BLF LEDs
monitor hints. However, the hints are getting confused and inverting state
sometimes. That is, unused extensions are being shown as in-use, and
vice-versa.

If I run "sip show inuse" during these times, I see entries like this:

steerpike*CLI> sip show inuse
* User name               In use          Limit
mjc_server                0               10
mjc_library               0               10
mjc_lab                   0               10
mjc_office                0               10
mjc_home                  0               10
* Peer name               In use          Limit
mjc_server                0/0/0           10
mjc_library               0/0/0           10
mjc_lab                   -1/0/0          10
mjc_office                0/0/0           10
mjc_home                  0/0/0           10

Note the "-1"! This is nonsense, and results in an "in use" hint:

steerpike*CLI> core show hints
                    601 at internal            : SIP/mjc_office&SIP/m 
State:InUse           Watchers 11

where the defined hint is:

exten =>
601,hint,SIP/mjc_office&SIP/mjc_home&SIP/mjc_lab&SIP/mjc_server&SIP/mjc_library


Somehow, the call count is being decremented by 2 after a hangup (from 1
to -1). Call counts should be clamped at zero, I would suggest.

This problem did not occur on the same system when we had 1.2.x and 1.4.x
running.

- Mike
====================================================================== 

---------------------------------------------------------------------- 
 (0094957) putnopvut (administrator) - 2008-11-17 17:40
 http://bugs.digium.com/view.php?id=13668#c94957 
---------------------------------------------------------------------- 
I gave this patch a review. As far as fixing the bug is concerned, this
does the trick. Good job with this, wolfelectric!

The problem I have with the patch is that it does an absolutely horrendous
job of conforming to the coding guidelines as outlined in
doc/CODING-GUIDELINES in the Asterisk source. Specifically, the mixed use
of tabs and spaces at the beginnings of lines and the lack of spaces to
separate tokens are things that jumped out at me.

Other things that are frowned upon in the patch include the large block of
code that is marked for removal pending successful tests. Patches submitted
should be submitted in such a way that they can be committed as-is. Also,
referring to bug numbers in debug messages is not encouraged.

All of this being said, the actual implementation of the patch is good,
and I will commit it after I have cleaned it up to conform to coding
guidelines. I have run out of time today, but I expect to do this when I
get in to work tomorrow morning. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-17 17:40 putnopvut      Note Added: 0094957                          
======================================================================