[asterisk-bugs] [Asterisk 0013703]: Abort in free in queue show <name> command

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13703 
====================================================================== 
Reported By:                davidw
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13703
Category:                   Applications/app_queue
Reproducibility:            have not tried
Severity:                   crash
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-15 08:56 CDT
Last Modified:              2008-11-14 10:53 CST
====================================================================== 
Summary:                    Abort in free in queue show <name> command
Description: 
We were getting bogus queue not found messages from the QUEUE_MEMBER (and
QUEUE_MEMBER_COUNT function), so after running "queue show", which gave the
truncated queue name, we tried queue show <name> with the full name.
====================================================================== 

---------------------------------------------------------------------- 
 (0094903) svnbot (reporter) - 2008-11-14 10:53
 http://bugs.digium.com/view.php?id=13703#c94903 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 156883

U   trunk/UPGRADE.txt
U   trunk/apps/app_queue.c
U   trunk/include/asterisk/strings.h

------------------------------------------------------------------------
r156883 | mmichelson | 2008-11-14 10:53:36 -0600 (Fri, 14 Nov 2008) | 24
lines

Fix some refcounting in app_queue.c and change the
hashing used by app_queue.c to be case-insensitive.
This is accomplished by adding a new case-insensitive
hashing function.

This was necessary to prevent bad refcount errors
(and potential crashes) which would occur due to the
fact that queues were initially read from the config
file in a case-sensitive manner. Then, when a user
issued a CLI command or manager action, we allowed
for case-insensitive input and used that input to 
directly try to find the queue in the hash table. The result
was either that we could not find a queue that was input or
worse, we would end up hashing to a completely bogus value
based on the input.

This commit resolves the problem presented in
issue http://bugs.digium.com/view.php?id=13703. However, that issue was reported
against
1.6.0. Since this fix introduces a behavior change, I am
electing to not place this same fix in to the 1.6.0 or 1.6.1
branches, and instead will opt for a change which does not
change behavior.


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=156883 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-14 10:53 svnbot         Checkin                                      
2008-11-14 10:53 svnbot         Note Added: 0094903                          
======================================================================