[asterisk-bugs] [Asterisk 0013898]: [patch] Limit connect file and others will not play warnings

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13898 
====================================================================== 
Reported By:                alecdavis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13898
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 155671 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-11-13 19:11 CST
Last Modified:              2008-11-14 09:32 CST
====================================================================== 
Summary:                    [patch] Limit connect file and others will not play
warnings
Description: 
LIMIT_CONNECT_FILE
LIMIT_WARNING_FILE
LIMIT_TIMEOUT_FILE

All appear to have corrupt pointers when the time comes to play the file.
They show correctly for the call.

The test macro limits the call to 20 seconds, warning at 15, frequency 10
seconds. (Note to myself, frequency too long!)
====================================================================== 

---------------------------------------------------------------------- 
 (0094901) Corydon76 (administrator) - 2008-11-14 09:32
 http://bugs.digium.com/view.php?id=13898#c94901 
---------------------------------------------------------------------- 
Unfortunately, your patch isn't entirely safe, either, because it depends
upon 3 channel variables not changing between the time they are checked and
used.  This is a legitimate concern because a manager session can change
the values of any channel variables at any time when the channel is
unlocked.  If this were to happen, your cached pointers would be pointing
towards more garbage space.  I have, however, fixed this with another
patch, which allocates memory on the heap and frees those pointers at the
appropriate time.

Some testing would be appreciated. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-14 09:32 Corydon76      Note Added: 0094901                          
======================================================================