[asterisk-bugs] [DAHDI-linux 0013742]: Ignored return value of down_interruptible()

Asterisk Bug Tracker noreply at bugs.digium.com
Wed Nov 5 13:59:54 CST 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13742 
====================================================================== 
Reported By:                smurfix
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   13742
Category:                   dahdi (the module)
Reproducibility:            random
Severity:                   major
Priority:                   normal
Status:                     acknowledged
====================================================================== 
Date Submitted:             2008-10-20 00:27 CDT
Last Modified:              2008-11-05 13:59 CST
====================================================================== 
Summary:                    Ignored return value of down_interruptible()
Description: 
This will cause severe consistency problems if somebody ever presses ^C at
the wrong time.

/tmp/mis/usr_src/modules/dahdi/drivers/dahdi/wctdm24xxp/GpakCust.c:411:
warning: ignoring return value of ‘down_interruptible’, declared with
attribute warn_unused_result

/tmp/mis/usr_src/modules/dahdi/drivers/dahdi/wcte12xp/vpmadt032.c:1067:
warning: ignoring return value of ‘down_interruptible’, declared with
attribute warn_unused_result

====================================================================== 

---------------------------------------------------------------------- 
 (0094598) svnbot (reporter) - 2008-11-05 13:59
 http://bugs.digium.com/view.php?id=13742#c94598 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 5236

U   linux/trunk/drivers/dahdi/wctdm24xxp/GpakCust.c
U   linux/trunk/drivers/dahdi/wcte12xp/vpmadt032.c

------------------------------------------------------------------------
r5236 | sruffell | 2008-11-05 13:59:53 -0600 (Wed, 05 Nov 2008) | 11 lines

Check the return value of the down_interruptible call in order to quiet a
warning.  This semaphore does not protect any host data structures, but
only
accesses to the VPMADT032 module.  The worse thing that could happen is
that
the internal state of the VPM module is corrupted, and then would only
happen
on module loading because otherwise access because that is the only time
this
function is called in the context of a user process.  In this case, the
module
would need to be reloaded again anyway.

(Closes issue http://bugs.digium.com/view.php?id=13742) 
Reported by smurfix

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=5236 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-05 13:59 svnbot         Checkin                                      
2008-11-05 13:59 svnbot         Note Added: 0094598                          
======================================================================




More information about the asterisk-bugs mailing list