[asterisk-bugs] [Asterisk 0013841]: The ackcall feature in agent's configurations is misinterpreted

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13841 
====================================================================== 
Reported By:                clegall_proformatique
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13841
Category:                   Channels/chan_agent
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.22 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 154365 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-11-05 10:25 CST
Last Modified:              2008-11-05 10:33 CST
====================================================================== 
Summary:                    The ackcall feature in agent's configurations is
misinterpreted
Description: 
Admin problem : While the "ackcall" parameter is never set, the ack seems
to be always required.


Seen on line 2456 of channels/chan_agent.c :
		if (strcasecmp(ackcall_s, "always"))
instead of
		if (!strcasecmp(ackcall_s, "always"))
or
		if (strcasecmp(ackcall_s, "always") == 0)
which I prefer.


====================================================================== 

---------------------------------------------------------------------- 
 (0094585) svnbot (reporter) - 2008-11-05 10:33
 http://bugs.digium.com/view.php?id=13841#c94585 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 154724

U   branches/1.4/channels/chan_agent.c

------------------------------------------------------------------------
r154724 | mmichelson | 2008-11-05 10:33:23 -0600 (Wed, 05 Nov 2008) | 6
lines

The logic of a strcasecmp call was reversed

(closes issue http://bugs.digium.com/view.php?id=13841)
Reported by: clegall_proformatique


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=154724 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-05 10:33 svnbot         Checkin                                      
2008-11-05 10:33 svnbot         Note Added: 0094585                          
======================================================================