[asterisk-bugs] [Asterisk 0011849]: Missing CDR's for Transfers

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11849 
====================================================================== 
Reported By:                greyvoip
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   11849
Category:                   CDR/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.17 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-01-26 11:11 CST
Last Modified:              2008-11-03 09:49 CST
====================================================================== 
Summary:                    Missing CDR's for Transfers
Description: 
At the moment there is one CDR generated per generic bridge. This tends not
to create any problems when the bridge has been created by something like:

SIP User -> Asterisk -> PSTN

The CDR generated will have the PSTN number as the destination and the SIP
User's accountcode.

When a transfer is undertaken the one CDR per generic bridge approach
breaks down. An example call flow for a blind transfer is:

SIP User -> Asterisk -> PSTN
PSTN <- Asterisk -> PSTN (this is after the user has blind transferred the
first call to a second PSTN number)

At the moment Asterisk will correctly generate a CDR for the first call
leg but for the second call leg there is a problem. For the sconed call leg
both ends of the bridge are now billable but as Asterisk only generates a
single CDR per bridge one of the legs will not get billed. 

A straight forward fix (at least architecturally) would be to generate a
CDR for each end of the bridge instead of combining both ends into a single
CDR. It would mean some extra CDR's for the standard SIP User -> PSTN call
but it's a lot easier to filter out CDR's to ignore than it is to try and
work out how to handle ones that are missing.

I've classified this as major since it's costing me (and other providers)
money every time a user does a transfer :).
====================================================================== 

---------------------------------------------------------------------- 
 (0094520) mdu113 (reporter) - 2008-11-03 09:49
 http://bugs.digium.com/view.php?id=11849#c94520 
---------------------------------------------------------------------- 
frawd, I love your approach. I've worked out several most common cases and
they all seemed to be covered. Also with this approach I can see the
potential to finally properly account for parked calls. Imagine if channel
being connected to parked channel inherits its CDRs. Can't wait for murf to
comment on it.

greyvoip, I think that your approach is probably more correct conceptually
and I guess it will cover all possible scenarios including parking, but it
will completely break all existing asterisk-based billing system. I think
if that is to be implemented it should be added as an option. Both systems
have to exists concurrently for some time, so that users have time for
transition.

murf, i've tested your patch and sip transfers (the only ones I use). For
sip transfers the BLINDTRANSFER variable is correctly set to transferrer. I
would still suggest we use different variable name for attended transfer.
Also regardless of what will be done with CDRs this can be useful by
itself, so please don't discard this change. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-11-03 09:49 mdu113         Note Added: 0094520                          
======================================================================