[asterisk-bugs] [Asterisk 0012451]: join empty categories are not the same as leavewhenempty ones, joinempty probably wrong

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12451 
====================================================================== 
Reported By:                davidw
Assigned To:                svnbot
====================================================================== 
Project:                    Asterisk
Issue ID:                   12451
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 114060 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             04-15-2008 11:14 CDT
Last Modified:              05-30-2008 16:17 CDT
====================================================================== 
Summary:                    join empty categories are not the same as
leavewhenempty ones, joinempty probably wrong
Description: 
Once one accounts for joinempty and leavewhenempty sort of having opposite
logical senses, one cannot match the effects of the values of these two
variables one for one.

joinempty = no matches leavewhenempty = yes

joinempty = yes matches leavewhenempty = no

However, joinempty = strict drops only for QUEUE_NO_REACHABLE_MEMBERS,
but

leavewhenempty = strict drops for both QUEUE_NO_MEMBERS and
QUEUE_NO_REACHABLE_MEMBERS.

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 05-30-08 16:17  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 119420

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_queue.c

------------------------------------------------------------------------
r119420 | tilghman | 2008-05-30 16:17:35 -0500 (Fri, 30 May 2008) | 22
lines

Merged revisions 119419 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r119419 | tilghman | 2008-05-30 16:23:14 -0500 (Fri, 30 May 2008) | 14
lines

Merged revisions 119404 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r119404 | tilghman | 2008-05-30 16:17:45 -0500 (Fri, 30 May 2008) | 6
lines

When joinempty=strict, it only failed on join if there were busy members. 
If
all members were logged out OR paused, then it (incorrectly) let callers
join
the queue.
(closes issue http://bugs.digium.com/view.php?id=12451)
 Reported by: davidw

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=119420 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-30-08 16:17  svnbot         Checkin                                      
05-30-08 16:17  svnbot         Note Added: 0087586                          
======================================================================