[asterisk-bugs] [Asterisk 0012193]: PARKINGEXTEN misbehaves when it is not a canonical form number and can double park or destroy the 700 entry

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12193 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12193
Category:                   Resources/res_features
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 101988 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-12-2008 06:53 CDT
Last Modified:              05-30-2008 06:18 CDT
====================================================================== 
Summary:                    PARKINGEXTEN misbehaves when it is not a canonical
form number and can double park or destroy the 700 entry
Description: 
If you set PARKINGEXTEN to "XXXX" it gets treated as 0.  (I think it would
also not be identiried as duplicate, if re-used, but I only have the
console at the moment.)

If you set it to "-1XXXX", it is handled correctly, with the exception
that it gets announced as minus one.

If you set it to "0700", it overwrites the system generated Park() line,
and removes it completely when the parking completes.

If you set it to "0701", it is treated as 701, however, I believe that it
would fail to detect the duplication and double park the call (I'd need two
phones, on the system I'm learning on, to demonstrate this other than by
code reading).

At some time, before the formal test run, I managed to get one with an
empty name created, which wouldn't go away, but I couldn't work out how to
reproduce that.

I will attach console traces, interleaved with the relevant extension.conf
lines.  Note that these traces also demonstrate a problem with returning
calls on timeout, which I intend to report separately.
====================================================================== 

---------------------------------------------------------------------- 
 davidw - 05-30-08 06:18  
---------------------------------------------------------------------- 
Apologies.  This is on a home system and I'm technically on leave at the
moemnt.

Park looks good enough.  Parkandannounce is broken, but I'm not sure how
well I tested it before (I had other problems with it that were since
fixed).  I'm still not convinced about the final if statement, but that is
a secondary issue, and I need to work out a test scenario to break it.


For Park:
0700 is rejected as exists =- OK
-1XXXX is rejected as not valid OK
0701 is treated as being 701 OK  (I'm assuming that, as 0700 is detected
as duplicate, 0701 would be considered to duplicate an existing 701.)
0XXX is treated as zero. Harmless.
700XXX is rejected as exists. OK, although one could argue for the last
two both being invalid.


For Parkandannounce:

To be added as an edit.  But in summary, the lot seems to be coming out as
zero and is being announced as "" (invalid).  The incoming line is being
left in Ringing state and, although it is the console, console hangup is
ignored. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-30-08 06:18  davidw         Note Added: 0087536                          
======================================================================