[asterisk-bugs] [Asterisk 0012755]: [patch] parking space number is announced to the parkee instead of the parker

[noreply at bugs.digium.com]

The following issue has been SUBMITTED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12755 
====================================================================== 
Reported By:                nreinartz
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12755
Category:                   Resources/res_features
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.20.1 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-29-2008 10:37 CDT
Last Modified:              05-29-2008 10:37 CDT
====================================================================== 
Summary:                    [patch] parking space number is announced to the
parkee instead of the parker
Description: 
If call parking is done by res/res_features.c, park_call_exec() the parking
space number is announced to the parkee but it should be announced to the
parker.
Revision 97529 (
http://svn.digium.com/view/asterisk/branches/1.4/res/res_features.c?view=log#rev97529
   ) introduced a fix and stated out "Fix saying the parking space number
to the caller doing the parking ..." but its not working as described.
Until revision 97529 the parking space wasn't announced. Now its
announced, but it's announced to the parkee not to the parker.

Most of the channel drivers do parking directly by ast_park_call() if the
number matches with ast_parking_ext(). If the number doesn't match,
ast_async_goto() is called which goes through the dial plan.
ast_async_goto() calls the registered application park_call_exec().
Unfortunately this function doesn't include the peer channel as parameter.
Thus it's not possible to announce the parking space number to the parker.
A design with both channels as parameters would be great.

I tested with some snom phones using the park orbit function. Usually
parking is done by ast_park_call(), I had to use a special configuration,
so that parking is done by park_call_exec(). See attached file
"configuration.txt".

The attached patch doesn't solve the whole problem, but with this patch
the parker is at least called back after parking timeout. 
I tested this for chan_sip, it works for me. The patch also undoes the fix
of revision 97529.
====================================================================== 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-29-08 10:37  nreinartz      Asterisk Version          => 1.4.20.1        
05-29-08 10:37  nreinartz      SVN Branch (only for SVN checkou => N/A          
  
======================================================================