[asterisk-bugs] [Asterisk 0011721]: When using ForkCDR Asterisk does not set the duration and billsec correcty

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11721 
====================================================================== 
Reported By:                voipgate
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   11721
Category:                   Applications/app_forkcdr
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 92122 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-09-2008 19:46 CST
Last Modified:              05-28-2008 19:19 CDT
====================================================================== 
Summary:                    When using ForkCDR Asterisk does not set the
duration and billsec correcty
Description: 
When using ForkCDR and the call has not been answered, Asterisk creates 2
cdr's but one of them lacks the data for billsec and duration. The purpose
of a fork is to create 2 cdrs but with different variables (accountcode,
userfield) but the duration and bill seconds as well as the disposition
must be set.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012726 ForkCDR application fails to set duration
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 05-28-08 19:19  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 118858

U   branches/1.4/apps/app_forkcdr.c
U   branches/1.4/main/cdr.c

------------------------------------------------------------------------
r118858 | murf | 2008-05-28 19:19:02 -0500 (Wed, 28 May 2008) | 46 lines

(closes issue http://bugs.digium.com/view.php?id=10668)
(closes issue http://bugs.digium.com/view.php?id=11721)
(closes issue http://bugs.digium.com/view.php?id=12726)
Reported by: arkadia
Tested by: murf

These changes:

1. revert the changes made via bug 10668; 
   I should have known that such changes,
   even tho they made sense at the time,
   seemed like an omission, etc, were actually
   integral to the CDR system via forkCDR.
   It makes sense to me now that forkCDR didn't
   natively end any CDR's, but rather depended
   on natively closing them all at hangup time
   via traversing and closing them all, whether
   locked or not. I still don't completely 
   understand the benefits of setvar and answer
   operating on locked cdrs, but I've seen 
   enough to revert those changes also, and
   stop messing up users who depended on that
   behavior. bug 12726 found reverting the changes
   fixed his changes, and after a long review
   and working on forkCDR, I can see why.
2. Apply the suggested enhancements proposed
   in 10668, but in a completely compatible
   way. ForkCDR will behave exactly as before,
   but now has new options that will allow some
   actions to be taken that will slightly 
   modify the outcome and side-effects of
   forkCDR. Based on conversations I've had 
   with various people, these small tweaks
   will allow some users to get the behavior
   they need. For instance, users executing
   forkCDR in an AGI script will find the
   answer time set, and DISPOSITION set, 
   a situation not covered when the routines
  were first written.
3. A small problem in the cdr serializer
   would output answer and end times even
   when they were not set. This is now 
   fixed.



------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=118858 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-28-08 19:19  svnbot         Checkin                                      
05-28-08 19:19  svnbot         Note Added: 0087476                          
======================================================================