[asterisk-bugs] [Asterisk 0012742]: [patch] janitor project for getvar_helper in app_queue

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12742 
====================================================================== 
Reported By:                snuffy
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   12742
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 118332 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-28-2008 12:03 CDT
Last Modified:              05-28-2008 14:50 CDT
====================================================================== 
Summary:                    [patch] janitor project for getvar_helper in
app_queue
Description: 
Some fixes to make accessing to returned values for getvar_helper
threadsafe.

Also noted small improvement to check for mixmonitor application before
parsing out extra arguements to mixmonitor as per discussion with putnoput
on irc.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 05-28-08 14:50  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 118783

U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r118783 | mmichelson | 2008-05-28 14:49:57 -0500 (Wed, 28 May 2008) | 15
lines

Update to the janitor project for making sure to be thread-safe when
retrieving the value of a channel variable. This covers app_queue.

This commit also incorporates a logical change. Previously, if MixMonitor
is to be used to record the call, all the arguments were parsed first.
Then
the MixMonitor app would be located. Now the order of these operations has
been swapped. Now the app is located first so that we only go through the
work of parsing the arguments if the app was found.

(closes issue http://bugs.digium.com/view.php?id=12742)
Reported by: snuffy
Patches:
      bug_12742.diff uploaded by snuffy (license 35)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=118783 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-28-08 14:50  svnbot         Note Added: 0087462                          
======================================================================