[asterisk-bugs] [Asterisk 0012735]: [patch] Compatibilty wrapper for Macro to use GoSub

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12735 
====================================================================== 
Reported By:                atis
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   12735
Category:                   Applications/NewFeature
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 118253 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-28-2008 04:13 CDT
Last Modified:              05-28-2008 08:24 CDT
====================================================================== 
Summary:                    [patch] Compatibilty wrapper for Macro to use GoSub
Description: 
This is replacement for app_macro and enables compatibility with AEL parser
in 1.6. AEL parser is internally changing "macro" declarations and usage to
GoSub, but this is not compatible with realtime dialplan. 

This simple wrapper doesn't in any way implements full functionality of
Macro, but allows simple calls from realtime dialplan to Macro work as they
were calls to macro from AEL.

Therefore app_macro can be disabled in default menuselect as it's usage is
discouraged and this enabled for compatibility.

====================================================================== 

---------------------------------------------------------------------- 
 Corydon76 - 05-28-08 08:24  
---------------------------------------------------------------------- 
1) The formatting is incorrect.  Please see the CODING GUIDELINES.
2) You're using strsep, instead of using the standard argument parsing
macros.  Please see app_skel.c for an example.
3) This needs a big warning in the application help that says that it does
NOT emulate the functionality of Macro; it is just a wrapper to make
interfacing to AEL easier.

Frankly, given how it does not even come close to addressing the full
functionality of Macro, I don't see how I could even set this as the
default Macro application.  I'm not even sure if I want the confusion that
it may generate of adding it to the Asterisk core. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-28-08 08:24  Corydon76      Note Added: 0087412                          
======================================================================