[asterisk-bugs] [Asterisk 0012687]: [patch] rc.debian.asterisk ubuntu 8.04 hardy

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12687 
====================================================================== 
Reported By:                loloski
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12687
Category:                   General
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-19-2008 21:54 CDT
Last Modified:              05-23-2008 18:56 CDT
====================================================================== 
Summary:                    [patch] rc.debian.asterisk ubuntu 8.04 hardy
Description: 
Good day, today i stumble on hardy as to how asterisk would start, i found
out that this particular section of script

	if [ "${VERSION:0:8}" = "Asterisk" ]; then # otherwise "Unable t"
 		echo "Asterisk is already running.  $0 will exit now."
 		exit 1
 	fi

is not applicable if your are using a #!/bin/sh interpreter instead of
#!/bin/bash, on redhat system or equivalent /bin/sh is a symlink of
/bin/bash


a simple fix for this is to replace #!/bin/sh with #!/bin/bash or please
see attached patch for details 

====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 05-23-08 18:56  
---------------------------------------------------------------------- 
While it sort of fixes the immediate issue (bashism), this is still broken:
there are better ways to check for a process that leaves a PID file. This
will break if there is another instance of Asterisk that uses a different
PID file.

Worse, it will hang the init script altogether if the asterisk process is
there bug does not respond.

(and may be meaningless in the case of safe_asterisk, of course). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-23-08 18:56  tzafrir        Note Added: 0087292                          
======================================================================