[asterisk-bugs] [Asterisk 0012674]: [branch] revert ast_queue_hangup and create ast_queue_hangup_with_cause

noreply at bugs.digium.com noreply at bugs.digium.com
Thu May 22 15:13:23 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12674 
====================================================================== 
Reported By:                mvanbaak
Assigned To:                mvanbaak
====================================================================== 
Project:                    Asterisk
Issue ID:                   12674
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 117135 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             05-17-2008 08:05 CDT
Last Modified:              05-22-2008 15:13 CDT
====================================================================== 
Summary:                    [branch] revert ast_queue_hangup and create
ast_queue_hangup_with_cause
Description: 
Recently, ast_queue_hangup got an extra parameter to set the hangupcause.
Some people told me that was not ok and there should be an
ast_queue_hangup_with_cause.
The second thing in this commit that was not ok, was the use of
ast_frame.seqno for the hangupcause.
I addressed that in this patch as well.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 05-22-08 15:13  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 117957

_U  team/seanbright/resolve-shadow-warnings/
U   team/seanbright/resolve-shadow-warnings/apps/app_alarmreceiver.c
U   team/seanbright/resolve-shadow-warnings/apps/app_chanspy.c
U   team/seanbright/resolve-shadow-warnings/apps/app_dial.c
U   team/seanbright/resolve-shadow-warnings/apps/app_disa.c
U   team/seanbright/resolve-shadow-warnings/apps/app_externalivr.c
U   team/seanbright/resolve-shadow-warnings/apps/app_festival.c
U   team/seanbright/resolve-shadow-warnings/apps/app_followme.c
U   team/seanbright/resolve-shadow-warnings/apps/app_ices.c
U   team/seanbright/resolve-shadow-warnings/apps/app_jack.c
U   team/seanbright/resolve-shadow-warnings/apps/app_meetme.c
U   team/seanbright/resolve-shadow-warnings/apps/app_milliwatt.c
U   team/seanbright/resolve-shadow-warnings/apps/app_mp3.c
U   team/seanbright/resolve-shadow-warnings/apps/app_nbscat.c
U   team/seanbright/resolve-shadow-warnings/apps/app_queue.c
U   team/seanbright/resolve-shadow-warnings/apps/app_sms.c
U   team/seanbright/resolve-shadow-warnings/apps/app_speech_utils.c
U   team/seanbright/resolve-shadow-warnings/apps/app_test.c
U   team/seanbright/resolve-shadow-warnings/apps/app_zapbarge.c
U   team/seanbright/resolve-shadow-warnings/apps/app_zapscan.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_alsa.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_console.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_gtalk.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_h323.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_iax2.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_jingle.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_local.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_mgcp.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_misdn.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_nbs.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_oss.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_phone.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_sip.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_skinny.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_unistim.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_zap.c
U   team/seanbright/resolve-shadow-warnings/channels/iax2-parser.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_a_mu.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_adpcm.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_alaw.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_g722.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_g726.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_gsm.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_lpc10.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_resample.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_speex.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_ulaw.c
U   team/seanbright/resolve-shadow-warnings/codecs/codec_zap.c
U   team/seanbright/resolve-shadow-warnings/configs/jabber.conf.sample
U   team/seanbright/resolve-shadow-warnings/formats/format_g723.c
U   team/seanbright/resolve-shadow-warnings/formats/format_g726.c
U   team/seanbright/resolve-shadow-warnings/formats/format_g729.c
U   team/seanbright/resolve-shadow-warnings/formats/format_gsm.c
U   team/seanbright/resolve-shadow-warnings/formats/format_h263.c
U   team/seanbright/resolve-shadow-warnings/formats/format_h264.c
U   team/seanbright/resolve-shadow-warnings/formats/format_ilbc.c
U   team/seanbright/resolve-shadow-warnings/formats/format_jpeg.c
U   team/seanbright/resolve-shadow-warnings/formats/format_ogg_vorbis.c
U   team/seanbright/resolve-shadow-warnings/formats/format_pcm.c
U   team/seanbright/resolve-shadow-warnings/formats/format_sln.c
U   team/seanbright/resolve-shadow-warnings/formats/format_sln16.c
U   team/seanbright/resolve-shadow-warnings/formats/format_vox.c
U   team/seanbright/resolve-shadow-warnings/formats/format_wav.c
U   team/seanbright/resolve-shadow-warnings/formats/format_wav_gsm.c
U   team/seanbright/resolve-shadow-warnings/funcs/func_speex.c
U   team/seanbright/resolve-shadow-warnings/include/asterisk/channel.h
U   team/seanbright/resolve-shadow-warnings/include/asterisk/frame.h
U   team/seanbright/resolve-shadow-warnings/main/abstract_jb.c
U   team/seanbright/resolve-shadow-warnings/main/app.c
U   team/seanbright/resolve-shadow-warnings/main/asterisk.c
U   team/seanbright/resolve-shadow-warnings/main/audiohook.c
U   team/seanbright/resolve-shadow-warnings/main/channel.c
U   team/seanbright/resolve-shadow-warnings/main/dsp.c
U   team/seanbright/resolve-shadow-warnings/main/features.c
U   team/seanbright/resolve-shadow-warnings/main/file.c
U   team/seanbright/resolve-shadow-warnings/main/frame.c
U   team/seanbright/resolve-shadow-warnings/main/indications.c
U   team/seanbright/resolve-shadow-warnings/main/manager.c
U   team/seanbright/resolve-shadow-warnings/main/rtp.c
U   team/seanbright/resolve-shadow-warnings/main/slinfactory.c
U   team/seanbright/resolve-shadow-warnings/main/translate.c
U   team/seanbright/resolve-shadow-warnings/main/udptl.c
U   team/seanbright/resolve-shadow-warnings/res/res_adsi.c
U   team/seanbright/resolve-shadow-warnings/res/res_agi.c
U   team/seanbright/resolve-shadow-warnings/res/res_musiconhold.c

------------------------------------------------------------------------
r117957 | seanbright | 2008-05-22 15:13:18 -0500 (Thu, 22 May 2008) | 92
lines

Merged revisions
117792,117794,117802,117812,117822,117825,117828,117834,117870,117900 via
svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r117792 | seanbright | 2008-05-22 11:49:17 -0400 (Thu, 22 May 2008) | 1
line

Minor text fix.  roster -> resource.
................
r117794 | mmichelson | 2008-05-22 12:05:18 -0400 (Thu, 22 May 2008) | 3
lines

Committing a fix pointed out by Atis Lezdins on the asterisk-dev list.
Thanks!


................
r117802 | mvanbaak | 2008-05-22 12:29:54 -0400 (Thu, 22 May 2008) | 21
lines

- revert change to ast_queue_hangup and create ast_queue_hangup_with_cause
- make data member of the ast_frame struct a named union instead of a void

Recently the ast_queue_hangup function got a new parameter, the
hangupcause
Feedback came in that this is no good and that instead a new function
should be created.
This I did.

The hangupcause was stored in the seqno member of the ast_frame struct.
This is not very
elegant, and since there's already a data member that one should be used.
Problem is, this member was a void *.
Now it's a named union so it can hold a pointer, an uint32 and there's a
padding in case someone
wants to store another type in there in the future.

This commit is so massive, because all ast_frame.data uses have to be
altered to ast_frame.data.data

Thanks russellb and kpfleming for the feedback.

(closes issue http://bugs.digium.com/view.php?id=12674)
Reported by: mvanbaak

................
r117812 | tilghman | 2008-05-22 12:50:32 -0400 (Thu, 22 May 2008) | 13
lines

Blocked revisions 117809 via svnmerge

........
r117809 | tilghman | 2008-05-22 11:47:03 -0500 (Thu, 22 May 2008) | 6
lines

Take into account the length of delimiters when calculating result string
length.
(closes issue http://bugs.digium.com/view.php?id=12696)
 Reported by: adomjan
 Patches: 
       func_realtime.c-longdelimiter.patch uploaded by adomjan (license
487)

........

................
r117822 | mvanbaak | 2008-05-22 13:06:00 -0400 (Thu, 22 May 2008) | 2
lines

forgot chan_misdn

................
r117825 | mvanbaak | 2008-05-22 13:08:18 -0400 (Thu, 22 May 2008) | 2
lines

oops

................
r117828 | qwell | 2008-05-22 13:10:53 -0400 (Thu, 22 May 2008) | 1 line

Fix a few places where frame data was used directly.
................
r117834 | mvanbaak | 2008-05-22 13:16:08 -0400 (Thu, 22 May 2008) | 2
lines

chan_console fixes because of ast_frame.data => ast_frame.data.ptr

................
r117870 | mvanbaak | 2008-05-22 13:50:40 -0400 (Thu, 22 May 2008) | 2
lines

one more place I forgot

................
r117900 | tilghman | 2008-05-22 14:54:41 -0400 (Thu, 22 May 2008) | 10
lines

Merged revisions 117899 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r117899 | tilghman | 2008-05-22 13:53:53 -0500 (Thu, 22 May 2008) | 2
lines

Also remove preamble from asynchronous events (reported by jsmith on
#asterisk-dev)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=117957 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-22-08 15:13  svnbot         Note Added: 0087223                          
======================================================================




More information about the asterisk-bugs mailing list