[asterisk-bugs] [Asterisk 0012690]: Queue timeout terminates call attempt, causing partial ring

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12690 
====================================================================== 
Reported By:                atis
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   12690
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-20-2008 11:25 CDT
Last Modified:              05-22-2008 07:00 CDT
====================================================================== 
Summary:                    Queue timeout terminates call attempt, causing
partial ring
Description: 
If queue timeout occurs while queue is trying to ring member, call attempt
is terminated, not executing any instructions further, and causing partial
ring, which can sometimes be even one second.

After discussion with putnopvut on irc, we came to conclusion that this is
bug.


====================================================================== 

---------------------------------------------------------------------- 
 atis - 05-22-08 07:00  
---------------------------------------------------------------------- 
For me timeout in queues config is 0, as i use timeout in Dial from local
channel (otherwise it would be impossible to handle NO ANSWER there)

After looking to Your patch, i started debugging that myself, and came to
conclusion that this is what I would want. However, I'm not really sure how
it will affect timeoutrestart (purpose of which i don't understand)

Here's comparison of both timeout calculations:
<pre>
e->expire | qe->expire - now | qe->parent->timeout | to (current) | to
(proposed)
===========|==================|=====================|==============|===============
   T+20    |       20         |       10            |     10000    |  
10000
   T+10    |       10         |       10            |     10000    |  
10000
    T+5    |        5         |       10            |     5000     |  
10000
     T     |        0         |       10            |       0      |    
0
   T+20    |       20         |        0            |     20000    |   
-1
   T+10    |       10         |        0            |     10000    |   
-1
    T+5    |        5         |        0            |     5000     |   
-1
     T     |        0         |        0            |       0      |    
0
     0     |       -T         |       10            |     10000    |  
10000
     0     |       -T         |        5            |     5000     |  
5000
     0     |       -T         |        0            |      -1      |   
-1
</pre> 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-22-08 07:00  atis           Note Added: 0087199                          
======================================================================