[asterisk-bugs] [Asterisk 0012674]: [branch] revert ast_queue_hangup and create ast_queue_hangup_with_cause

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12674 
====================================================================== 
Reported By:                mvanbaak
Assigned To:                mvanbaak
====================================================================== 
Project:                    Asterisk
Issue ID:                   12674
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 117135 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-17-2008 08:05 CDT
Last Modified:              05-21-2008 18:27 CDT
====================================================================== 
Summary:                    [branch] revert ast_queue_hangup and create
ast_queue_hangup_with_cause
Description: 
Recently, ast_queue_hangup got an extra parameter to set the hangupcause.
Some people told me that was not ok and there should be an
ast_queue_hangup_with_cause.
The second thing in this commit that was not ok, was the use of
ast_frame.seqno for the hangupcause.
I addressed that in this patch as well.
====================================================================== 

---------------------------------------------------------------------- 
 mvanbaak - 05-21-08 18:27  
---------------------------------------------------------------------- 
01:31 <      MuffinMan> [117710] Committed by mvanbaak on
2008-05-21T23:16:39.395757Z: 00:48 <@      russellb> so ... even with the
named union, you can't use initializers ?
01:31 <      MuffinMan> ..00:48 <@      russellb> struct ast_frame f = {
.data.ptr = NULL };
01:31 <      MuffinMan> ..00:48 <@      russellb> ?
01:31 <      MuffinMan> ..00:48 <       mvanbaak> russellb: hhmm, where is
that
01:31 <      MuffinMan> ..00:48 <       mvanbaak> I think I used that
01:31 <      MuffinMan> ..00:49 <@      russellb> main/audiohook.c, for
example
01:31 <      MuffinMan> ..00:49 <@      russellb> -       .data = buf,
01:31 <      MuffinMan> ..00:49 <@      russellb>         .datalen =
sizeof(buf),
01:32 <      MuffinMan> ..00:49 <@      russellb>         .samples =
samples,
01:32 <      MuffinMan> ..00:49 <@      russellb>     };
01:32 <      MuffinMan> ..00:49 <@      russellb> +   frame.data.ptr =
buf;
01:32 <      MuffinMan> ..00:49 <       mvanbaak> ah
01:32 <      MuffinMan> ..00:49 <@      russellb> aside from a few places
where that was changed, it looks good
01:32 <      MuffinMan> ..00:49 <       mvanbaak> that must be because of
my earlier work on the anonymous union
01:32 <      MuffinMan> ..00:50 <@      russellb> mvanbaak: yeah
01:32 <      MuffinMan> ..
01:32 <      MuffinMan> ..Fixed that. Now I can use it in in an
initializer.
01:32 <      MuffinMan> ..
01:32 <      MuffinMan> ..Please have a look at this so I can commit it
(or you can)
01:32 <      MuffinMan> ..This looks better then current trunk anyways 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-21-08 18:27  mvanbaak       Note Added: 0087188                          
======================================================================