[asterisk-bugs] [Asterisk 0012693]: sip reload doesn't add new peers

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12693 
====================================================================== 
Reported By:                marsosa
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   12693
Category:                   Core/Configuration
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta8 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-20-2008 19:08 CDT
Last Modified:              05-20-2008 21:14 CDT
====================================================================== 
Summary:                    sip reload doesn't add new peers
Description: 
I'm testing 1.6.0beta8 and beta9 and in both versions i have the same
problem: when i add new peers to a file included in sip.conf and then do a
sip reload (or full reload) the new peer doesn't appears to be added until
a full restart.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 05-20-08 21:14  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 117367

U   trunk/main/config.c

------------------------------------------------------------------------
r117367 | mmichelson | 2008-05-20 21:14:27 -0500 (Tue, 20 May 2008) | 19
lines

Be sure that we cache included files for each source file which loads
a configuration file.  As it was, only the first did so. This led to 
a problem if the included file was changed (but not the configuration 
file which includes it) and the second source file attempted to reload 
the configuration. It would not see that the included file had changed.

In this particular example, res_phoneprov and chan_sip both loaded
sip.conf, which included a file call sip.peers.conf. Since res_phoneprov
was the first to load sip.conf, only it cached the fact that sip.conf
included sip.peers.conf. If sip.peers.conf were changed and sip.conf were
not and a sip reload were issued (meaning that chan_sip attempts to 
reload sip.conf only if it and its included files have changed) the
changes
made to sip.peers.conf would not be seen and therefore no action would be
taken.

(closes issue http://bugs.digium.com/view.php?id=12693)
Reported by: marsosa


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=117367 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-20-08 21:14  svnbot         Checkin                                      
05-20-08 21:14  svnbot         Note Added: 0087094                          
======================================================================