[asterisk-bugs] [Asterisk 0012652]: Whenever I issue reload, I get "No [csv] section in cdr.conf. Unregistering backend."

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12652 
====================================================================== 
Reported By:                DennisD
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   12652
Category:                   CDR/cdr_csv
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta8 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-14-2008 14:05 CDT
Last Modified:              05-14-2008 22:55 CDT
====================================================================== 
Summary:                    Whenever I issue reload, I get "No [csv] section in
cdr.conf.  Unregistering backend."
Description: 

It looks like this COULD be the problem:

In cdr_csv.c:

    if (!(cfg = ast_config_load(config, config_flags))) {
        ast_log(LOG_WARNING, "unable to load config: %s\n", config);
        return 0;
    } else if (cfg == CONFIG_STATUS_FILEUNCHANGED)
        return 0;

Shouldn't line 107 return 1 if the config file status unchanged?


====================================================================== 

---------------------------------------------------------------------- 
 murf - 05-14-08 22:55  
---------------------------------------------------------------------- 
Just about every module (everywhere) returns 0 (success) if it's unchanged.
The principle is that if the config file hasn't changed, you just skip
loading it again. Why would you want to DECLINE? Isn't that like an error;
wouldn't that unload the module?

Some modules tell you there were no changes, and that the config file was
skipped. That might be nicer, but the affect is the same. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-14-08 22:55  murf           Note Added: 0086893                          
======================================================================