[asterisk-bugs] [Zaptel 0011057]: Incorrect handling of international settings

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11057 
====================================================================== 
Reported By:                meneault
Assigned To:                mattf
====================================================================== 
Project:                    Zaptel
Issue ID:                   11057
Category:                   wcfxo
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 3211 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-23-2007 02:23 CDT
Last Modified:              05-13-2008 14:06 CDT
====================================================================== 
Summary:                    Incorrect handling of international settings
Description: 
There is a simple error of hexadecimal/decimal in wcfxo.c which cause the
driver to ignore its international settings.
====================================================================== 

---------------------------------------------------------------------- 
 meneault - 05-13-08 14:06  
---------------------------------------------------------------------- 
ipconvergence -- your issues seem strange. What patch version do you use?
(i.e. patch -v -- personally I use patch 2.5.9)? Are your sure you are
using latest zaptel 1.4 from SVN repository (revision 4250)?
Anyway adding the line (in mode patch) in your kernel/wcfxo.c would do for
your own testing...

tzafrir -- I am happy with your solution to use fxo_modes.h but it is
highly wctdm specific. Borrowing the currently defined fields would still
require modes definition in wcfxo.c and using two different structures
would be too much IMHO.
But factorizing fxo_modes for both wcfxo and wctdm (maybe with a union or
a simple #ifdef) would be a good idea. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-13-08 14:06  meneault       Note Added: 0086807                          
======================================================================