[asterisk-bugs] [Asterisk 0012597]: duplicate function calls to get_header() in find_call()

noreply at bugs.digium.com noreply at bugs.digium.com
Tue May 13 13:31:25 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12597 
====================================================================== 
Reported By:                hooi
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   12597
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 114190 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             05-07-2008 04:17 CDT
Last Modified:              05-13-2008 13:31 CDT
====================================================================== 
Summary:                    duplicate function calls to get_header() in
find_call()
Description: 
In rev 114190, chan_sip.c, lines 6154-6157 are redundant as the variable
"callid", "from", "to", and "cseq" are already initialized in lines
6148-6151.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 05-13-08 13:31  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 115885

_U  team/group/newcdr/
U   team/group/newcdr/channels/chan_h323.c
U   team/group/newcdr/channels/chan_iax2.c
U   team/group/newcdr/channels/chan_sip.c
U   team/group/newcdr/contrib/scripts/asterisk.ldap-schema
U   team/group/newcdr/contrib/scripts/asterisk.ldif
_U  team/group/newcdr/include/asterisk/dlinkedlists.h
U   team/group/newcdr/main/sched.c
U   team/group/newcdr/res/res_config_ldap.c
U   team/group/newcdr/res/res_odbc.c
U   team/group/newcdr/sounds/Makefile

------------------------------------------------------------------------
r115885 | murf | 2008-05-13 13:31:15 -0500 (Tue, 13 May 2008) | 110 lines

Merged revisions
115507,115509,115513,115515,115518-115519,115521,115523,115525,115535,115537
via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
r115507 | file | 2008-05-07 07:41:25 -0600 (Wed, 07 May 2008) | 4 lines

Remove redundant header getting.
(closes issue http://bugs.digium.com/view.php?id=12597)
Reported by: hooi

................
r115509 | tilghman | 2008-05-07 07:49:15 -0600 (Wed, 07 May 2008) | 6
lines

Update typos in description fields
(closes issue http://bugs.digium.com/view.php?id=12598)
 Reported by: suretec
 Patches: 
       asterisk_schema_changes.patch uploaded by suretec (license 70)

................
r115513 | russell | 2008-05-07 11:28:19 -0600 (Wed, 07 May 2008) | 19
lines

Merged revisions 115512 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r115512 | russell | 2008-05-07 11:24:09 -0500 (Wed, 07 May 2008) | 11
lines

Merged revisions 115511 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r115511 | russell | 2008-05-07 11:22:49 -0500 (Wed, 07 May 2008) | 3 lines

Remove remnants of dlinkedlists.  I didn't actually use them in the final
version
of my IAX2 improvements.

........

................

................
r115515 | russell | 2008-05-07 11:38:36 -0600 (Wed, 07 May 2008) | 2 lines

re-add dlinkedlists.h to trunk, oops!

................
r115518 | russell | 2008-05-07 12:17:43 -0600 (Wed, 07 May 2008) | 12
lines

Blocked revisions 115517 via svnmerge

........
r115517 | russell | 2008-05-07 13:17:19 -0500 (Wed, 07 May 2008) | 5 lines

Track peer references when stored in the sip_pvt struct as the peer
related to
a qualify ping or a subscription.  This fixes some realtime related
crashes.
(closes issue http://bugs.digium.com/view.php?id=12588)
(closes issue http://bugs.digium.com/view.php?id=12555)

........

................
r115519 | russell | 2008-05-07 12:24:51 -0600 (Wed, 07 May 2008) | 2 lines

Let chan_h323 build in dev mode

................
r115521 | russell | 2008-05-07 12:30:12 -0600 (Wed, 07 May 2008) | 7 lines

Use the default that the log output claims will be used for the basedn

(closes issue http://bugs.digium.com/view.php?id=12599)
Reported by: suretec
Patches:
      12599.patch uploaded by juggie (license 24)

................
r115523 | russell | 2008-05-07 12:33:50 -0600 (Wed, 07 May 2008) | 6 lines

Only save a password if a username exists.

(closes issue http://bugs.digium.com/view.php?id=12600)
Reported By: suretec
Patch by me

................
r115525 | tilghman | 2008-05-07 12:40:21 -0600 (Wed, 07 May 2008) | 2
lines

Don't free the object on destroy, as astobj2 takes care of that for you

................
r115535 | tilghman | 2008-05-07 14:22:09 -0600 (Wed, 07 May 2008) | 2
lines

Advance to next sounds release

................
r115537 | russell | 2008-05-07 15:11:33 -0600 (Wed, 07 May 2008) | 10
lines

Fix up a problem that was introduced into the scheduler when it was
converted
to use doubly linked lists.  The schedule() function had an optimization
that
had it try to guess which direction would be better for the traversal to
insert
the task into the scheduler queue.  However, if the code chose the path
where
it traversed the queue in reverse, and the result was that the task should
be
at the head of the queue, then the code would actually put it at the tail,
instead.

(Problem found by bbryant, debugged and fixed by bbryant and me)

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=115885 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-13-08 13:31  svnbot         Note Added: 0086799                          
======================================================================




More information about the asterisk-bugs mailing list