[asterisk-bugs] [Asterisk 0012609]: potential segfault if tmpchan is NULL

[noreply at bugs.digium.com]

The following issue has been SUBMITTED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12609 
====================================================================== 
Reported By:                edantie
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12609
Category:                   Core/PBX
Reproducibility:            N/A
Severity:                   trivial
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 115517 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-08-2008 05:22 CDT
Last Modified:              05-08-2008 05:22 CDT
====================================================================== 
Summary:                    potential segfault if tmpchan is NULL
Description: 
in pbx.c
In pbx.c

function:

int ast_async_goto(struct ast_channel *chan, const char *context, const
char *exten, int priority)



04611       struct ast_channel *tmpchan = ast_channel_alloc(0,
chan->_state, 0, 0, chan->accountcode, chan->exten, chan->context,
chan->amaflags, "AsyncGoto/%s", chan->name);
04612       if (chan->cdr) {
04613          ast_cdr_discard(tmpchan->cdr);
04614          tmpchan->cdr = ast_cdr_dup(chan->cdr);  /* share the love
*/
04615       }
04616       if (!tmpchan)
04617          res = -1;
04618       else {


lines 4612-4615  should be moved after 4618
====================================================================== 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-08-08 05:22  edantie        Asterisk Version          => SVN             
05-08-08 05:22  edantie        SVN Branch (only for SVN checkou =>  1.4         
  
05-08-08 05:22  edantie        SVN Revision (number only!) => 115517          
======================================================================