[asterisk-bugs] [Asterisk 0012454]: [patch] SS7 support for chan_zap is missing clean-up code

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12454 
====================================================================== 
Reported By:                moy
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12454
Category:                   Channels/chan_zap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 114164 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-15-2008 20:28 CDT
Last Modified:              05-06-2008 21:38 CDT
====================================================================== 
Summary:                    [patch] SS7 support for chan_zap is missing clean-up
code
Description: 
I was adding code to chan_zap for MFR2 support and I took as example the
SS7 stuff. I realized it seems to be missing proper thread and CLI clean
up. Is not unregistering the CLI commands it register on load time and is
not shutting down the threads with pthread_cancel. The attached patch
address both issues.
====================================================================== 

---------------------------------------------------------------------- 
 moy - 05-06-08 21:38  
---------------------------------------------------------------------- 
weeeell it was not my intention to open a can of worms, but ... indeed even
unloading when only analog channels are present can cause leaks, since some
memory seems to be allocated in do_monitor without using thread keys that
can be destroyed when the thread is cancelled.

In anycase, I think at least this should be commited and then further
analysis can be made for chan_zap unloading, I just looked at the code and
that bug appeared in front of my eyes, not that I think is the only one on
chan_zap :-) 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-06-08 21:38  moy            Note Added: 0086512                          
======================================================================