[asterisk-bugs] [Asterisk 0012454]: [patch] SS7 support for chan_zap is missing clean-up code

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12454 
====================================================================== 
Reported By:                moy
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12454
Category:                   Channels/chan_zap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 114164 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-15-2008 20:28 CDT
Last Modified:              05-06-2008 14:47 CDT
====================================================================== 
Summary:                    [patch] SS7 support for chan_zap is missing clean-up
code
Description: 
I was adding code to chan_zap for MFR2 support and I took as example the
SS7 stuff. I realized it seems to be missing proper thread and CLI clean
up. Is not unregistering the CLI commands it register on load time and is
not shutting down the threads with pthread_cancel. The attached patch
address both issues.
====================================================================== 

---------------------------------------------------------------------- 
 mattf - 05-06-08 14:47  
---------------------------------------------------------------------- 
While this is a good thing IMHO, and a step in the right direction, there
are deeper issues here with the unload that will fail not just for SS7
linksets but also for PRIs.

chan_zap isn't in a state where unload can be done safely with PRI and SS7
channels types (and probably analog channels as well), so if you are
playing with this, you will find other problems (besides the very obvious
things such as application unregistering, etc). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-06-08 14:47  mattf          Note Added: 0086484                          
======================================================================