[asterisk-bugs] [Asterisk 0012475]: [patch] message about number of new and old messages not properly conjugated in Russian

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12475 
====================================================================== 
Reported By:                chappell
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12475
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-18-2008 09:35 CDT
Last Modified:              05-02-2008 11:38 CDT
====================================================================== 
Summary:                    [patch] message about number of new and old messages
not properly conjugated in Russian
Description: 
This is an old patch which we have been using for over a year.  Without it
the introductory message about how many voicemail messages are in the new
and old boxes is garbled.  The problems include dropt works, bad grammar,
and wrong counts.  As best I remember the patch fixes these problems:

* removed bad exception code for the Russian word for "one" in the neuter
singular
* due to confusion one of the counts of messages was wrong
* fixed conjugation of the adjectives meaning "old" and "new"

If necessary, I can go back and study the old code in order to accurately
describe exactly how it garbles the message.



====================================================================== 

---------------------------------------------------------------------- 
 chappell - 05-02-08 11:38  
---------------------------------------------------------------------- 
I missed the fact that somebody copied the Russian greeting function, fixed
some of the bugs, and made a Ukrainian function out of it.  Plus, somebody
else got in a fix for some (but not all) of the Russian bugs a day or two
before I did.  I have a corrected patch which I will post shortly.

I would be happy to prepare a document explaining how to record sound
files for other languages, but first we need to provide a language-neutral
version of the voicemail greeting and mailbox name functions.  Otherwise
the document would just say, "copy-and-paste the English functions and hack
away!"

The voicemail greeting function would need two new functions in say.c. 
These functions would put language-dependent endings on nouns and
adjectives when counting things.  For example, the function for nouns would
add "s" for two and above.  (For some languages the rules are much more
complicated.)  I believe there is a Polish-only implementation of some of
this in Asterisk-Addons.

I am preparing a more radical version of my patch which provides a
language-neutral version of vm_intro() and say.c functions with word ending
rules for English and Russian.  My patch would switch Russian over to the
language-neutral functions.

Though my patch would not be in the code path for any language other than
Russian I am afraid it might be to radical to be accepted simply because it
touches three files: app_voicemail.c, say.c, and say.h.  Any thoughts? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
05-02-08 11:38  chappell       Note Added: 0086315                          
======================================================================