[asterisk-bugs] [Zaptel 0012241]: [patch] New Ztdynamic driver for Redfone Communications foneBRIDGE 2 platform

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12241 
====================================================================== 
Reported By:                brettcar
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   12241
Category:                   NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Zaptel Version:             1.4.9.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-17-2008 12:50 CDT
Last Modified:              03-31-2008 12:24 CDT
====================================================================== 
Summary:                    [patch] New Ztdynamic driver for Redfone
Communications foneBRIDGE 2 platform
Description: 
Attached is the current production code used for Redfone's foneBRIDGE 2
platform that utilizes multiframe ztdynamic/ztd-eth packets. Makefiles et
cetera not included but could be provided if needed -- it's just a standard
module like ztd-eth.
====================================================================== 

---------------------------------------------------------------------- 
 russell - 03-31-08 12:24  
---------------------------------------------------------------------- 
1) The copyright header on this module indicates that someone other than
the submitter of the code did most of the work.  What is the history here? 
Brett, did you get these modifications made and you own this work? 
Otherwise, we have to ensure that the original author has a license on file
for his contributions.

2) I have not done an extensive code review on this module.  However, one
thing I noticed at a quick glance was open coded linked lists.  We should
not be introducing any new code with this.  It should use the kernel linked
list implementation, instead. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-31-08 12:24  russell        Note Added: 0084797                          
======================================================================