[asterisk-bugs] [Asterisk 0012299]: [patch] Can't pickup if pickupcode include #

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12299 
====================================================================== 
Reported By:                IgorG
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12299
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-26-2008 04:34 CDT
Last Modified:              03-27-2008 05:11 CDT
====================================================================== 
Summary:                    [patch] Can't pickup if pickupcode include #
Description: 
This issue is similar to http://bugs.digium.com/view.php?id=0010681

I have 'pickupexten = http://bugs.digium.com/view.php?id=43' in features.conf
and when dialed notice:

[Mar 26 15:35:15] NOTICE[14791]: chan_sip.c:16484 handle_request_invite:
Call from '102' to extension '%2343' rejected because extension not found.

If change 'pickupexten = %2343' but it is unexpected behavior.

Also I need to clear one thing: extension and all codes in features.conf
is escaped strings or no? Current code for incoming SIP check for both
escaped and unescaped extensions. And I not sure that it is right.

My patch looks only looks for unescaped strings in extensions.conf.
Also I'll correct log message on line 16460, that always print escaped
exten.
====================================================================== 

---------------------------------------------------------------------- 
 IgorG - 03-27-08 05:11  
---------------------------------------------------------------------- 
Oej, patch work. Also I upload my patch with one fixed log message that
output exten escaped non-human-readable.

Before:
[Mar 27 16:08:24] NOTICE[16291]: chan_sip.c:16448 handle_request_invite:
Call from '102' to extension '%238555' rejected because extension not
found.

After:
[Mar 27 16:08:24] NOTICE[16291]: chan_sip.c:16448 handle_request_invite:
Call from '102' to extension 'http://bugs.digium.com/view.php?id=8555' rejected
because extension not found. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-27-08 05:11  IgorG          Note Added: 0084646                          
======================================================================