[asterisk-bugs] [Asterisk 0012299]: [patch] Can't pickup if pickupcode include #

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12299 
====================================================================== 
Reported By:                IgorG
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12299
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-26-2008 04:34 CDT
Last Modified:              03-26-2008 10:53 CDT
====================================================================== 
Summary:                    [patch] Can't pickup if pickupcode include #
Description: 
This issue is similar to http://bugs.digium.com/view.php?id=0010681

I have 'pickupexten = http://bugs.digium.com/view.php?id=43' in features.conf
and when dialed notice:

[Mar 26 15:35:15] NOTICE[14791]: chan_sip.c:16484 handle_request_invite:
Call from '102' to extension '%2343' rejected because extension not found.

If change 'pickupexten = %2343' but it is unexpected behavior.

Also I need to clear one thing: extension and all codes in features.conf
is escaped strings or no? Current code for incoming SIP check for both
escaped and unescaped extensions. And I not sure that it is right.

My patch looks only looks for unescaped strings in extensions.conf.
Also I'll correct log message on line 16460, that always print escaped
exten.
====================================================================== 

---------------------------------------------------------------------- 
 IgorG - 03-26-08 10:53  
---------------------------------------------------------------------- 
I can test it only tomorrow, but obviously it will work because of this
code after variable definition:

	if (pedanticsipchecking)
		ast_uri_decode(tmp);
	uri = get_in_brackets(tmp);


I think it is not right solution for this situation, because as of RFC SIP
URI is always escaped string. I do not understand why in this situation we
need enabled 'pedantic' in SIP for unescape this. Is decoding of URI cause
some problem? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-26-08 10:53  IgorG          Note Added: 0084585                          
======================================================================