[asterisk-bugs] [Asterisk 0012214]: [patch] Added event based MWI to chan_skinny

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12214 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12214
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 108392 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-14-2008 10:59 CDT
Last Modified:              03-25-2008 18:38 CDT
====================================================================== 
Summary:                    [patch] Added event based MWI to chan_skinny
Description: 
Modelled on chan_zap and chan_mgcp.  I have been chasing a segfault
that initially appeared to be related to IMAP and voicemail.  After
looking at way too many core dumps I finally noticed that while the
crash occured in the c-client code, the call trace always pointed
to starting in the do_housekeeping finction in chan_skinny.

The function do_housekeeping calls has_voicemail which in chan_skinny
is just a call to ast_app_has_voicemail.  I reworked the do_housekeeping
and has_voicemail functions to resemble their counterparts in chan_zap
and chan_mgcp.

So far I have not been able to recreate the segfault with light VM
interaction, were as before the patch one call would typically trigger
the dump.
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 03-25-08 18:38  
---------------------------------------------------------------------- 
+if (!ast_strlen_zero(mailbox)) {
+	char *mailbox, *context;

That bothers me slightly.  Can you rename the variables that have the same
name (I realize scope is fine, but it's a bit confusing if you're trying to
follow a variable).

Besides some minor whitespace issues, it looks alright.  Unfortunately, my
7970 is acting stupid (thanks Cisco), so I can't test this.. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-25-08 18:38  qwell          Note Added: 0084545                          
======================================================================