[asterisk-bugs] [Zaptel 0012241]: [patch] New Ztdynamic driver for Redfone Communications foneBRIDGE 2 platform

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12241 
====================================================================== 
Reported By:                brettcar
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   12241
Category:                   NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Zaptel Version:             1.4.9.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-17-2008 12:50 CDT
Last Modified:              03-20-2008 14:38 CDT
====================================================================== 
Summary:                    [patch] New Ztdynamic driver for Redfone
Communications foneBRIDGE 2 platform
Description: 
Attached is the current production code used for Redfone's foneBRIDGE 2
platform that utilizes multiframe ztdynamic/ztd-eth packets. Makefiles et
cetera not included but could be provided if needed -- it's just a standard
module like ztd-eth.
====================================================================== 

---------------------------------------------------------------------- 
 tzafrir - 03-20-08 14:38  
---------------------------------------------------------------------- 
Another matter of style: ztdethmf_rcv() and ztdethmf_transmit() could use
some reduced nesting.

e.g: in ztdethmf_create:

instead of:

if (z) {
  some_long_code;
}
return z;


use:

if (!z)
  return NULL;
some_long_code;

In other places got-s may help. Also in the same place above: is there a
better way to fail when there's not enough memory? 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-20-08 14:38  tzafrir        Note Added: 0084355                          
======================================================================