[asterisk-bugs] [Asterisk 0011663]: [patch] prevent a segfault

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=11663 
====================================================================== 
Reported By:                junky
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   11663
Category:                   Resources/res_musiconhold
Reproducibility:            sometimes
Severity:                   crash
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 93163 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-01-2008 17:44 CST
Last Modified:              03-19-2008 14:07 CDT
====================================================================== 
Summary:                    [patch] prevent a segfault
Description: 
I just got my box crashing:

(gdb) bt
http://bugs.digium.com/view.php?id=0  0xb7c6cc53 in strlen () from
/lib/tls/i686/cmov/libc.so.6
http://bugs.digium.com/view.php?id=1  0x080abade in ast_openstream_full
(chan=0xb6c0f850, filename=0x0,
preflang=0xb6c4ea08 "fr", asis=1) at file.c:541
http://bugs.digium.com/view.php?id=2  0xb78e6779 in moh_files_generator
(chan=0xb6c0f850, data=0x82baa30,
len=320, samples=160) at res_musiconhold.c:255
http://bugs.digium.com/view.php?id=3  0x0808ada1 in ast_read_generator_actions
(chan=0xb6c0f850,
f=0x8299734) at channel.c:2102
http://bugs.digium.com/view.php?id=4  0x0808b477 in __ast_read (chan=0xb6c0f850,
dropaudio=0) at
channel.c:2481
http://bugs.digium.com/view.php?id=5  0xb71d0078 in conf_run (chan=0xb6c0f850,
conf=0x81f9080,
confflags=37196, optargs=0xb661d588) at app_meetme.c:2257
http://bugs.digium.com/view.php?id=6  0xb71d73f8 in conf_exec (chan=0xb6c0f850,
data=0xb661de24) at
app_meetme.c:3176
http://bugs.digium.com/view.php?id=7  0x080d57f5 in pbx_exec (c=0xb6c0f850,
app=0x81f03e0, data=0xb661de24)
at pbx.c:719
http://bugs.digium.com/view.php?id=8  0xb7a54af0 in handle_exec
(chan=0xb6c0f850, agi=0xb661ddcc, argc=3,
argv=0xb661d7c8) at res_agi.c:1101
http://bugs.digium.com/view.php?id=9  0xb7a59022 in agi_handle_command
(chan=0xb6c0f850, agi=0xb661ddcc,
buf=<value optimized out>, dead=0) at res_agi.c:2169
http://bugs.digium.com/view.php?id=10 0xb7a5a520 in agi_exec_full
(chan=0xb6c0f850, data=<value optimized
out>, enhanced=0, dead=0) at res_agi.c:2309
http://bugs.digium.com/view.php?id=11 0x080d57f5 in pbx_exec (c=0xb6c0f850,
app=0x81ae730, data=0xb66211d8)
at pbx.c:719
http://bugs.digium.com/view.php?id=12 0x080df6f5 in pbx_extension_helper
(c=0xb6c0f850, con=0x0,
context=0xb6c0f9d4 "unlimitel-inbound", exten=0xb6c0fa24 "349", priority=1,
label=0x0, 
    callerid=0xb6c05610 "10", action=E_SPAWN, found=0xb66232f4,
combined_find_spawn=1) at pbx.c:2661
http://bugs.digium.com/view.php?id=13 0x080e2d2b in __ast_pbx_run (c=0xb6c0f850)
at pbx.c:3161
http://bugs.digium.com/view.php?id=14 0x080e435e in ast_pbx_run (c=0xb6623440)
at
/usr/src/asterisk/include/asterisk/lock.h:697
http://bugs.digium.com/view.php?id=15 0x0811cceb in dummy_start
(data=0xb6c3dbe0) at utils.c:838
http://bugs.digium.com/view.php?id=16 0xb7db2504 in start_thread () from
/lib/tls/i686/cmov/libpthread.so.0
http://bugs.digium.com/view.php?id=17 0xb7ccd51e in clone () from
/lib/tls/i686/cmov/libc.so.6
(gdb)
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 03-19-08 14:07  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 110035

U   branches/1.4/res/res_musiconhold.c

------------------------------------------------------------------------
r110035 | file | 2008-03-19 14:07:20 -0500 (Wed, 19 Mar 2008) | 4 lines

Add sanity checking for position resuming. We *have* to make sure that the
position does not exceed the total number of files present, and we have to
make sure that the position's filename is the same as previous. These
values can change if a music class is reloaded and give unpredictable
behavior.
(closes issue http://bugs.digium.com/view.php?id=11663)
Reported by: junky

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=110035 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-19-08 14:07  svnbot         Checkin                                      
03-19-08 14:07  svnbot         Note Added: 0084276                          
03-19-08 14:07  svnbot         Status                   feedback => assigned
03-19-08 14:07  svnbot         Assigned To               => file            
======================================================================