[asterisk-bugs] [Asterisk 0012235]: [patch] Improve LDAP server configuration for res_config_ldap

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12235 
====================================================================== 
Reported By:                tjormola
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   12235
Category:                   Resources/res_config_ldap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     needs license
Asterisk Version:           1.6.0-beta5 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-17-2008 11:35 CDT
Last Modified:              03-19-2008 13:30 CDT
====================================================================== 
Summary:                    [patch] Improve LDAP server configuration for
res_config_ldap
Description: 
This patch alters res_config_ldap.c so that full LDAP URL is used
internally to represent the LDAP server to use instead of using hostname
and port variables. It's also possible to specify the full URL in
res_ldap.conf using the new url keyword instead of just specifying host and
port (but this works too, of course, so existing configurations should not
break due to this change). Rationale behind this is that using a URL you
can specify extra settings for the connections that are not available
otherwise (e.g. you can use ldapi:// urls when connecting to a local
OpenLDAP server, or you can specify the scope of the queries, see
ldap_url(3) manual page for more info).

Also currently the port setting code is broken. It generates invalid LDAP
URLs if both host and port of the LDAP server is specified in the
configuration file.

The patch also fixes setting of the protocol. You can specify this in the
configuration file, but the setting was never applied to the LDAP
connection. Thus all connections were using LDAPv2 by default (at least
when Asterisk is compiled against OpenLDAP 2.4).
====================================================================== 

---------------------------------------------------------------------- 
 davidw - 03-19-08 13:30  
---------------------------------------------------------------------- 
I suspect you are referring to US law.  I think it is even more doubtful
that one could dedicate to the public domain internationally.  However,
even if the patch were dedicated to the public domain, the identity of the
dedicator would be necessary to provide traceability that it really had
been dedicated.

The real problem comes with trivial and obvious changes that are not
actually copyrightable in the first place; the terms of submission require
that these be treated as though they were copyrightable.

The current policy makes it very difficult for anyone employed in the
software industry to contribute even trivial fixes, as most will have
employment contracts that make even out of hours software work copyrights
the property of their employers, so they can't be submitted without going
through the employer's legal department.  (There are arguments that such
contracts are unfair, but I wouldn't want to do a test case, and, in any
case, Asterisk is of interest to my employers.) 

In this case, my impression from the description of the patch is that, at
least the first part, isn't trivial enough and therefore it will be
copyrightable.   I wouldn't have submitted it, even to someone who accepted
trivial patches, without my equivalent of the Yoyodyne release at the end
of the GPL. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-19-08 13:30  davidw         Note Added: 0084265                          
======================================================================