[asterisk-bugs] [Asterisk 0011429]: Sent RTP video packets have a timestamp based on a 8000 Hz clock instead of 90000 Hz when mark bit is on

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=11429 
====================================================================== 
Reported By:                sperreault
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   11429
Category:                   Core/RTP
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 90351 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             11-30-2007 14:53 CST
Last Modified:              03-19-2008 13:16 CDT
====================================================================== 
Summary:                    Sent RTP video packets have a timestamp based on a
8000 Hz clock instead of 90000 Hz when mark bit is on
Description: 
When you ast_write() a video packet, you are supposed to put the mark bit
into the LSB of the subclass member:

f->subclass = AST_FORMAT_H263 | 1;

This makes this conditional in ast_rtp_raw_write() true while it should be
false:

if (f->subclass & AST_FORMAT_AUDIO_MASK) {

The solution is simple: invert the video and audio code paths. First check
for video, and then if video is not present check for audio.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 03-19-08 13:16  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 110019

U   branches/1.4/main/rtp.c

------------------------------------------------------------------------
r110019 | file | 2008-03-19 13:16:17 -0500 (Wed, 19 Mar 2008) | 6 lines

Make sure that the mark bit does not incorrectly cause video frame
timestamps to be calculated as if they are audio frames.
(closes issue http://bugs.digium.com/view.php?id=11429)
Reported by: sperreault
Patches:
      11429-frametype.diff uploaded by qwell (license 4)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=110019 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-19-08 13:16  svnbot         Checkin                                      
03-19-08 13:16  svnbot         Note Added: 0084260                          
03-19-08 13:16  svnbot         Status                   new => assigned     
03-19-08 13:16  svnbot         Assigned To               => file            
======================================================================