[asterisk-bugs] [Asterisk 0012235]: [patch] Improve LDAP server configuration for res_config_ldap

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12235 
====================================================================== 
Reported By:                tjormola
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   12235
Category:                   Resources/res_config_ldap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     needs license
Asterisk Version:           1.6.0-beta5 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-17-2008 11:35 CDT
Last Modified:              03-19-2008 12:19 CDT
====================================================================== 
Summary:                    [patch] Improve LDAP server configuration for
res_config_ldap
Description: 
This patch alters res_config_ldap.c so that full LDAP URL is used
internally to represent the LDAP server to use instead of using hostname
and port variables. It's also possible to specify the full URL in
res_ldap.conf using the new url keyword instead of just specifying host and
port (but this works too, of course, so existing configurations should not
break due to this change). Rationale behind this is that using a URL you
can specify extra settings for the connections that are not available
otherwise (e.g. you can use ldapi:// urls when connecting to a local
OpenLDAP server, or you can specify the scope of the queries, see
ldap_url(3) manual page for more info).

Also currently the port setting code is broken. It generates invalid LDAP
URLs if both host and port of the LDAP server is specified in the
configuration file.

The patch also fixes setting of the protocol. You can specify this in the
configuration file, but the setting was never applied to the LDAP
connection. Thus all connections were using LDAPv2 by default (at least
when Asterisk is compiled against OpenLDAP 2.4).
====================================================================== 

---------------------------------------------------------------------- 
 tjormola - 03-19-08 12:19  
---------------------------------------------------------------------- 
Well can't the message that these patches are public domain be forwarded to
the lawyers for acceptance? I'm sorry, but your company's policy is very
unfriendly for casual voluntary contributors fixing bugs when talking about
trivial patches like this. Of course I do understand the need for solving
the possible licensing issues thorougly when it's about implementing
something new functionality, for which the contributor would retain
copyright unless otherwise stated, of course. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-19-08 12:19  tjormola       Note Added: 0084254                          
======================================================================