[asterisk-bugs] [Asterisk 0009077]: [patch] Playback(<file>|noanswer) and in-band info are not working with chan_skinny

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=9077 
====================================================================== 
Reported By:                pj
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   9077
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta4 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 53885 
Disclaimer on File?:        No 
Request Review:              
====================================================================== 
Date Submitted:             02-15-2007 13:08 CST
Last Modified:              03-18-2008 01:14 CDT
====================================================================== 
Summary:                    [patch] Playback(<file>|noanswer) and in-band info
are not working with chan_skinny
Description: 
tried to playback with noanswer option, it works with chan_sip or chan_iax,
but not with chan_skinny, also other inband info messages from telco are
not possible with chan_skinny.
eg.: when calling to unavailable gsm phone and telco operator says "person
you are calling isn't available" chan_skinny plays normal ringing tone,
chan_sip and chan_iax plays this in-band messages fine.
tested with ci$co 7920.
====================================================================== 

---------------------------------------------------------------------- 
 wedhorn - 03-18-08 01:14  
---------------------------------------------------------------------- 
I disagree with earlyrtp.

Basically the patches are:
 - earlyrtp: tell asterisk to do the tones
 - earlyrtp2: get chan_skinny to do the tones and from a single function
 - earlyrtp2a: same as earlyrtp2 plus ability to select tonezone

I think that basically throwing an error and getting asterisk to provide
the tones is incorrect. As much as everyone loves comparing skinny to
sip/iax, it must be understood that in configurability, it is actually
closer to zap (ok, I admit that IP is used as the transport, but that is
really the only similarity with SIP and IAX). A sip/iax device is
configurable. A skinny device is not. All of the configuration needs to be
done in chan_skinny.

sip_indicate only returns -1 (and gets asterisk to play them) if there
doesn't seem to be a reasonable way to signal the device. zt_indicate plays
the tones from within chan_zap and only returns -1 if the play fails.

Based on this, I think we should handle the tone playing within
chan_skinny. Also, I vote for the inclusion of the tonezone configuration
as there is nowhere else that it could be put to allow for per device
configuration.

All of that said, I am happy to do any work required in getting something
committed such as possibly treating old and new telephones differently due
to the ability of new phones to use signalling even when there is rtp.

Partially related and something I think needs fixing (although it applies
to a bunch of other channels), when I did the transfer stuff, I had to
inject tones if required at the transfer leg rather than just indicating to
the transferring channel that it should play a tone. This seems to be a
common approach, although I can't work out why. I follow suit because we
didn't have the ability to play tones inband, but with earlyrtp2, the
transfer could be cleaned up to just send and ast_indicate rather than
injecting a tone (other channels I think would also need some work). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-18-08 01:14  wedhorn        Note Added: 0084108                          
======================================================================