[asterisk-bugs] [Asterisk 0006725]: [patch] incapsulation of ast_best_codec(chan->nativeformats)

[noreply at bugs.digium.com]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=6725 
====================================================================== 
Reported By:                Mithraen
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   6725
Category:                   Core/NewFeature
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 50469 
Disclaimer on File?:        Yes 
Request Review:             Yes 
Resolution:                 won't fix
Fixed in Version:           
====================================================================== 
Date Submitted:             03-15-2006 03:07 CST
Last Modified:              03-17-2008 13:35 CDT
====================================================================== 
Summary:                    [patch] incapsulation of
ast_best_codec(chan->nativeformats)
Description: 
This patch is a part of my work for incapsulate must work with codecs.
That
needed for future changes with codec negotiation logic.

Added functions (all this functions static inline):
 
 - ast_chan_best_codec(chan) = ast_best_codec(chan->nativecodecs)
   This need, because in future nativecodecs can be changed from int to
struct
   type;
 - ast_get_read_format(chan) = chan->readformat
 - ast_get_write_format(chan) = chan->writeformat
 - ast_request_inherit -- wrapper around ast_request, that can:
    - copy type from parent channel, if type not set;
    - copy formats from parent channel;
 - ast_chan_getformatname  = ast_getformatname(chan->nativeformats)
 - ast_channel_format_reset =
        ast_set_read_format(chan->readformat);
        ast_set_write_format(chan->writeformat);

First patch adds new functions.
Second patch, switch most of Asterisk code to use new functions.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0006727 [patch] ast_get_readformat(chan) added
related to          0004825 [patch][post 1.4] New codec negotiation...
====================================================================== 

---------------------------------------------------------------------- 
 file - 03-17-08 13:35  
---------------------------------------------------------------------- 
Per Corydon, this is going to be taken care of in his new codec bits branch
and no longer applicable. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-17-08 13:35  file           Note Added: 0084085                          
======================================================================