[asterisk-bugs] [Asterisk-GUI 0012167]: [patch] Performance issues when loading many users in users.conf

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12167 
====================================================================== 
Reported By:                EduardoYC
Assigned To:                bkruse
====================================================================== 
Project:                    Asterisk-GUI
Issue ID:                   12167
Category:                   General
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     assigned
Asterisk Version:           Older 1.4 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 1752 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-07-2008 12:42 CST
Last Modified:              03-14-2008 12:14 CDT
====================================================================== 
Summary:                    [patch] Performance issues when loading many users
in users.conf
Description: 
Whenever the lists of users and queues were loaded (when loading the
users.html or queues.html), the functions "insert_option" and
"merge_extensions" (astman.js) are executed, reordering the full list for
every item inserted, thus a very slow process with lots of unnecessary
iterations. My users.conf file has about 1000 users, and it was impossible
to load the screens of Users and Queues (the browser got locked, showing an
alert about a script taking too long to complete). So I changed the
algorithm, sorting the lists only after all users or queues are loaded and
I also did a minor change in the functions "queuecallbacks.postselect" and
"queuecallbacks.newcategory" that loads users on the screen of queues,
adding a variable to temporarily store a generated html of user checkboxes,
avoiding another unnecessarily repetitive process.
====================================================================== 

---------------------------------------------------------------------- 
 bkruse - 03-14-08 12:14  
---------------------------------------------------------------------- 
I will take the responsibility of updating the patches as well when we can
fully commit into the branch, in the future (after this release). You have
done the work, the least I can do is keep them up to date and not make you
have to repatch :]

-bk 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-14-08 12:14  bkruse         Note Added: 0083982                          
======================================================================