[asterisk-bugs] [Asterisk 0012210]: Possible crash if chan is null

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12210 
====================================================================== 
Reported By:                edantie
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12210
Category:                   Resources/res_musiconhold
Reproducibility:            N/A
Severity:                   trivial
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 108679 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             03-14-2008 04:00 CDT
Last Modified:              03-14-2008 09:25 CDT
====================================================================== 
Summary:                    Possible crash if chan is null
Description: 
in res/res_musiconhold.c, line 211-215
<code>
static void moh_files_release(struct ast_channel *chan, void *data)
{
        struct moh_files_state *state = chan->music_state;

        if (chan && state) {
</code>

can crash if chan is NULL


====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 03-14-08 09:25  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 108682

U   branches/1.4/res/res_musiconhold.c

------------------------------------------------------------------------
r108682 | qwell | 2008-03-14 09:24:59 -0500 (Fri, 14 Mar 2008) | 4 lines

Fix a potential segfault if chan (or chan->music_state) is NULL.

Closes issue http://bugs.digium.com/view.php?id=12210, credit to edantie for
pointing this out.

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=108682 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-14-08 09:25  svnbot         Note Added: 0083948                          
03-14-08 09:25  svnbot         Status                   new => assigned     
03-14-08 09:25  svnbot         Assigned To               => qwell           
======================================================================