[asterisk-bugs] [Asterisk 0011827]: [patch] Add TCP socket support to app_externalivr.c

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11827 
====================================================================== 
Reported By:                ctooley
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   11827
Category:                   Applications/NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.17 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-23-2008 15:15 CST
Last Modified:              03-12-2008 16:56 CDT
====================================================================== 
Summary:                    [patch] Add TCP socket support to app_externalivr.c
Description: 
This change adds the ability to communicate over a TCP socket instead of
forking a child process.  Use by putting "ivr://eivrhost[:port]" in place
of the command inside ExternalIvr().
====================================================================== 

---------------------------------------------------------------------- 
 russell - 03-12-08 16:56  
---------------------------------------------------------------------- 
I have reviewed the latest patch.  Here are the last things that need to be
changed, and then it can be merged.

1) Fix compiling under --enable-dev-mode.  There are some vars in the
middle of a block.

2) eivr_comm() needs a new argument, which is the FILE * that was already
opened for the socket as a part of client_start().  Then if that is
provided, commands/events should be handled on that FILE *.  Also, be sure
to close that FILE * before freeing the instance struct.

3) There is now an ast_tcptls_server_instance_destroy() func.  Use it
instead of free() 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-12-08 16:56  russell        Note Added: 0083866                          
======================================================================