[asterisk-bugs] [Asterisk 0011817]: [branch] Ability to mark a voicemail message as URGENT.

[noreply at bugs.digium.com]

The following issue requires your FEEDBACK. 
====================================================================== 
http://bugs.digium.com/view.php?id=11817 
====================================================================== 
Reported By:                jaroth
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   11817
Category:                   Applications/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-22-2008 13:12 CST
Last Modified:              03-07-2008 13:52 CST
====================================================================== 
Summary:                    [branch] Ability to mark a voicemail message as
URGENT.
Description: 
This patch adds the ability to tag a voicemail as urgent.  It supports both
IMAP and file-based storage.  After recording a voicemail and pressing "#",
an additional option (4) is available to mark the message as urgent. 
Pressing the '4' key a second time turns the flag off.   In IMAP, the
message is marked as //FLAGGED, as well as the addition of an additional
email header "X-Asterisk-VM-Flag".  File-based storage uses an additional
attribute in the .txt file called "flag".  The subject line of notification
email will state that "you have an URGENT message" as well.  

In IMAP, when retrieving a message, all URGENT messages will be presented
first.  In file storage, urgent and new messages will be presented
together.  Because the URGENT flag is just that, and not a new directory,
urgent and new messages both appear in the INBOX.  

When accessing voicemail, the user will be prompted that they have X
urgent messages, Y new messages, and Z old messages.  The number of urgent
messages is also sent to extern_notify in case there needs to be special
handling of these messages outside of voicemail.

VMCOUNT will accept URGENT as a folder name to return the number of urgent
messages.

Some custom sound files were necessary and are included here for testing
purposes only.

The branch that contains this code is:

http://svn.digium.com/svn/asterisk/team/jrothenberger
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 03-07-08 13:52  
---------------------------------------------------------------------- 
I spent yesterday and this morning cleaning up the code and fixing bugs in
the asterisk-urgent branch. Here's a list of the revisions and a summary of
the changes:

106401: Coding guidelines cleanups
106432: Make buffer size of the urgent flag string consistent
106434: Remove useless variables from functions
106435: Remove an awkward sound file playback
106495: Fixed a bug where it was impossible to mark a message as urgent
when originating a voicemail from VoiceMailMain
106498: Corrected a bug where forwarded urgent messages were saved to the
INBOX instead of the urgent folder
106500: Constify some strings
106503: Fix the perusal of messages when you delete as you go.
106505: A function was called with the parameters out of order. I swapped
them.
106695: Remove an unused function
106702: Cleaned up some logic and made a comment explaining it.
106791: Changed a strncmp to a strcmp

At this point, I'm comfortable with the way that urgent messaging works
for IMAP and file-based storage. Now the problem is that there currently is
no ODBC storage support. As far as I'm concerned, the only things left to
do are:

1. Write ODBC support for urgent messages
2. Test that out thoroughly
3. Get the necessary sounds recorded

Then this will be ready for merge. Could you please get started on the
ODBC support? Thanks very much! 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-07-08 13:52  putnopvut      Note Added: 0083617                          
03-07-08 13:52  putnopvut      Status                   assigned => feedback
======================================================================