[asterisk-bugs] [Asterisk 0010585]: [RFC] export attended transfer functionality over AMI

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10585 
====================================================================== 
Reported By:                ornati
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   10585
Category:                   Core/ManagerInterface
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 81262 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-28-2007 14:00 CDT
Last Modified:              03-05-2008 16:23 CST
====================================================================== 
Summary:                    [RFC] export attended transfer functionality over
AMI
Description: 
Currently there's no way (that I know) to activate an attended tranfer
through the AMI, it would be useful for "controlling" GUIs etc...

This patch export this functionality and passed the "works for me" stage.

I'm interested in any type of feedback. In particular I'd like to know
what the interface should look like. Now it's really simple, it just takes
the "transferer" channel and the extension to transfer to. Should I also
add optional "Context" and "Priority"?
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 03-05-08 16:23  
---------------------------------------------------------------------- 
Okay, this patch was really well written and worked fine, BUT it we avoid
adding new control frames if at all possible, especially a control frame
which is only going to be used in one place in the code.

So, I used the same idea you had, except that instead of queueing a
control frame, I queue DTMF frames that correspond to what is set as the
attended transfer DTMF sequence defined in features.conf. This has a few
advantages: it only allows those who have permission to transfer calls to
transfer calls via the Manager interface, it requires only code in
manager.c to be changed, and there's no need to add a new control frame
type.

Thanks for the patch submission, it was a good one. I'm just sorry that it
didn't get taken care of sooner. Commit will be going into trunk soon... 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-05-08 16:23  putnopvut      Note Added: 0083497                          
======================================================================