[asterisk-bugs] [Asterisk 0010297]: [patch] Unload/load support for chan_skinny

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10297 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10297
Category:                   Channels/NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0-beta4 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 76940 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             07-25-2007 01:40 CDT
Last Modified:              03-05-2008 07:58 CST
====================================================================== 
Summary:                    [patch] Unload/load support for chan_skinny
Description: 
Reload is not working, but unload and load do work.
My reload code is ugly-simple, it calls the unload 
function, then the load function.  I would have thought
if I could manually unload and load that would be enough.


My threading knowledge is more than a bit weak, but the
existing code was 90% there already.  We needed to store
the address of the skinny_session thread launch from within
accept_thread so we could later cancel it.

Interestingly the skinnysession structure had a member to
store the thread address, but it did not appear to be used.

I also move the teardown of the accept thread to a point before
tearing down the sessions (and their threads) to prevent a phone
from trying to re-register and recreating a session thread after
we had processed it.


====================================================================== 

---------------------------------------------------------------------- 
 sbisker - 03-05-08 07:58  
---------------------------------------------------------------------- 
Is there a way to make it so that the reload command will work only when
there are no active chan_skinny channels.  Right now I have 2 asterisk
servers.  One for chan_skinny activity and one for everything else.  Reason
being, that every time I have to modify or add a skinny device, the server
has to be restarted.  Not good for a production system.  Just a thought. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-05-08 07:58  sbisker        Note Added: 0083426                          
======================================================================