[asterisk-bugs] [Asterisk 0011972]: tls transport often causes asterisk to lock

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11972 
====================================================================== 
Reported By:                pj
Assigned To:                jamesgolovich
====================================================================== 
Project:                    Asterisk
Issue ID:                   11972
Category:                   Channels/chan_sip/General
Reproducibility:            random
Severity:                   block
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 103313 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             02-11-2008 11:04 CST
Last Modified:              03-04-2008 17:32 CST
====================================================================== 
Summary:                    tls transport often causes asterisk to lock
Description: 
when asterisk is locked, no call or registration is processed,
this happened several times today and yesterday (tried several trunk
revisions)
currently haven't found thing, what causes the locking situation, 
it seems, that locking problem start appearing, after more peers start
using tls transport
my tls only peers are: asterisk trunk, asterisk beta2 and eyebeam
sofphone
+several udp clients.



====================================================================== 

---------------------------------------------------------------------- 
 jamesgolovich - 03-04-08 17:32  
---------------------------------------------------------------------- 
Theres a few other changes in here that were necessary to stop deadlocks. 
One was to only lock netlock for udp channels and the other was to change
the local in the monitor thread from a lock to a trylock.

Also I added a little sleeping when unloading the module to give it enough
time for any threads to die.  I was getting a strange crash when unloading
if the threads didn't die quick enough.

There were some other crashes happening when the SSL fd would go away but
server_write was still being called, so thats why I added the check for
ser->fd and set errno and return -1 there.

I'm compiling your branch right now and gonna hammer at it to see if I can
reproduce any crash or deadlocks 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
03-04-08 17:32  jamesgolovich  Note Added: 0083379                          
======================================================================