[asterisk-bugs] [Asterisk 0012956]: [patch] Convert chan_skinny's open-coded linked lists to the list macros

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12956 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12956
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 125947 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-30-2008 10:51 CDT
Last Modified:              06-30-2008 15:37 CDT
====================================================================== 
Summary:                    [patch] Convert chan_skinny's open-coded linked
lists to the list macros
Description: 
No new warnings or errors.  There are a number of quirks relating to
transfers and multiple calls on hold, but these exist in Trunk before
the patch.
====================================================================== 

---------------------------------------------------------------------- 
 DEA - 06-30-08 15:37  
---------------------------------------------------------------------- 
Version 2 addresses Russell's comments.

I found and fixed the issue with Transfers that was leaving the phone in
an
inconsistent state, as well as using the 'New Call' button when an
existing
call was on hold.  These changes could be applied seperately, and if the
linked-list conversion is not likely to make the 1.6 cut, I will provide
them in a seperate patch.

While the conversion/patch works, I am confused by AST_LIST_EMPTY and how
I ended up using it in skinny_hangup().  An empty list means the phone
only had one call associated with it and needs a different cleanup
process
than of the phone had multiple calls.

The comments for AST_LIST_EMPTY returns 0 if the list is empty, but
looking
at the macro definition and what I observed the code doing, the opposite
seems to be happening. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-30-08 15:37  DEA            Note Added: 0089445                          
======================================================================