[asterisk-bugs] [Asterisk 0012956]: [patch] Convert chan_skinny's open-coded linked lists to the list macros

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12956 
====================================================================== 
Reported By:                DEA
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12956
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 125947 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-30-2008 10:51 CDT
Last Modified:              06-30-2008 11:51 CDT
====================================================================== 
Summary:                    [patch] Convert chan_skinny's open-coded linked
lists to the list macros
Description: 
No new warnings or errors.  There are a number of quirks relating to
transfers and multiple calls on hold, but these exist in Trunk before
the patch.
====================================================================== 

---------------------------------------------------------------------- 
 russell - 06-30-08 11:51  
---------------------------------------------------------------------- 
1) Looks like you may have introduced a memory leak here:

@@ -1890,6 +1892,10 @@
 	if (!(req = req_alloc(sizeof(struct call_info_message),
CALL_INFO_MESSAGE)))
 		return;
 
+	/* We should not be able to get here without a session */
+	if (!s)
+		return;


2) AST_LIST_FIRST is not needed here

+	s = AST_LIST_FIRST(&sessions);
+	while((s = AST_LIST_REMOVE_HEAD(&sessions, list))) { 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-30-08 11:51  russell        Note Added: 0089440                          
======================================================================