[asterisk-bugs] [Asterisk 0012863]: Asterisk gives up on registration after receiving 408 Timeout response once

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12863 
====================================================================== 
Reported By:                ricvil
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12863
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.20 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-15-2008 20:28 CDT
Last Modified:              06-27-2008 16:54 CDT
====================================================================== 
Summary:                    Asterisk gives up on registration after receiving
408 Timeout response once
Description: 
This was originally reported under bug 12323.  I think it was closed
prematurely.  It was supposed to be fixed in 1.4.20 according to the
changelog:
  119 	* channels/chan_sip.c: Don't give up on attempting an outbound
  120 	  registration if we receive a 408 Timeout. (closes issue
http://bugs.digium.com/view.php?id=12323)

I just tried it today and the problem still happens.  The code is:
  12546         case 408:       /* Request timeout */
  12547                 ast_set_flag(&p->flags[0], SIP_NEEDDESTROY);
  12548                 r->call = NULL;
  12549                 AST_SCHED_DEL(sched, r->timeout);
  12550                 break;

But the only way I can get it to re-register again after receiving a 408
is by changing the code to:
  12546         case 408:       /* Request timeout */
  12547                 break;

Did anybody really test this out before closing bug 12323?  

It would also be nice to enable re-registration for a 404 response.  We
are running into an issue were a provider takes down its database for a few
minutes and during that timeframe we receive a '404 Not Found' when
attempting to register.  After that, Asterisk never registers again even
though the provider is back up and running normally.  It would be better
for Asterisk to rely on the sip.conf variable 'registerattempts' for these
cases rather than giving up after just one try.  
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012323 Asterisk gives up on registration after...
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-27-08 16:54  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 126056

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r126056 | tilghman | 2008-06-27 16:53:53 -0500 (Fri, 27 Jun 2008) | 4
lines

When we get a 408 Timeout, don't stop trying to re-register.
(closes issue http://bugs.digium.com/view.php?id=12863)
 Reported by: ricvil

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=126056 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-27-08 16:54  svnbot         Checkin                                      
06-27-08 16:54  svnbot         Note Added: 0089383                          
======================================================================