[asterisk-bugs] [Asterisk 0012908]: Wrong log level for one liner (ast_log LOG_WARNING) generates too much logging

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12908 
====================================================================== 
Reported By:                nito
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   12908
Category:                   Resources/res_config_ldap
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.0-beta9 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             06-21-2008 01:53 CDT
Last Modified:              06-21-2008 07:46 CDT
====================================================================== 
Summary:                    Wrong log level for one liner (ast_log LOG_WARNING)
generates too much logging
Description: 


The offending line is 

ast_log(LOG_WARNING, "Could not find any entry matching %s in base dn
%s.\n",
filter->str, clean_basedn);


This line will print into the log for all the non found entries in LDAP.

Example, if you have in you use ldap in your dialplan, then any entry that
is not matched or not partially matched will be logged.

Example:

[Jun 21 08:50:39] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=5021)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:50:39] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=_*)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:50:39] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=5021)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:50:39] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=_*)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:50:39] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=5021)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:50:39] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=_*)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.


And if you dial with an analog phone you would get something like

[Jun 21 08:52:23] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=5)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:23] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=_*)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:25] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=50)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:25] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=_*)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:25] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=502)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Qindel,dc=COM,o=Internet.
[Jun 21 08:52:25] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=_*)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:26] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=5023)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:26] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskExtension)(AstExtension=_*)(AstContext=sipclients)(AstPriority=1))
in base dn dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:34] WARNING[5243] res_config_ldap.c: Could not find any
entry matching (&(objectClass=AsteriskSIPUser)(uid=)) in base dn
dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:34] WARNING[5243] res_config_ldap.c: Could not find any
entry matching
(&(objectClass=AsteriskSIPUser)(uid=)(AstAccountHost=dynamic)) in base dn
dc=Company,dc=COM,o=Internet.
[Jun 21 08:52:34] WARNING[5243] res_config_ldap.c: Could not find any
entry matching (&(objectClass=AsteriskSIPUser)(uid=)) in base dn
dc=Company,dc=COM,o=Internet.

which I think does not describe a WARNING severity. For me a WARNING
severity is something that should attract the attention of the
administrator because it might lead to a problem (could lead to an error
condition). I don't think this is the case...

In numbers, be aware that this is for my personal configuration, this will
not match other people numbers, but could be indicative:

$ grep -c res_config_ldap /var/log/asterisk/messages
100523
grep res_config_ldap /var/log/asterisk/messages | grep -c "Could not find
any entry matching"
99186
$


====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-21-08 07:46  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 124505

U   trunk/res/res_config_ldap.c

------------------------------------------------------------------------
r124505 | tilghman | 2008-06-21 07:46:43 -0500 (Sat, 21 Jun 2008) | 4
lines

Reduce warning to debug, otherwise we flood the log when we (legitimately)
can't find a record.
(Closes issue http://bugs.digium.com/view.php?id=12908)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=124505 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-21-08 07:46  svnbot         Note Added: 0089050                          
======================================================================