[asterisk-bugs] [LibPRI 0012655]: Making calls through ZAP channels do not hangup

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12655 
====================================================================== 
Reported By:                Rudolf
Assigned To:                mattf
====================================================================== 
Project:                    LibPRI
Issue ID:                   12655
Category:                   General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             05-15-2008 03:51 CDT
Last Modified:              06-20-2008 08:46 CDT
====================================================================== 
Summary:                    Making calls through ZAP channels do not hangup
Description: 
After getting disconnect from telco call is not hangup and I can hear busy
sound from telco. I think we should send back disconnect acknowledge. After
30 seconds I get relase from telco.

I updated asterisk to versions

Asterisk 1.4.19.1
Zaptel 1.4.10.1
Libpri 1.4.4


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012870 chan_zap not dropping inbound ISDN call.
====================================================================== 

---------------------------------------------------------------------- 
 stevedavies - 06-20-08 08:46  
---------------------------------------------------------------------- 
Hi,

I just reverted the change.

This is the guilty patch.  All you have to do is remove those lines (the
ones below with the + at the front), and recompile your libpri:

Index: q931.c
===================================================================
--- q931.c      (revision 524)
+++ q931.c      (revision 528)
@@ -3716,6 +3716,12 @@
               UPDATE_OURCALLSTATE(pri, c,
Q931_CALL_STATE_DISCONNECT_INDICATION);
               c->peercallstate = Q931_CALL_STATE_DISCONNECT_REQUEST;
               c->sendhangupack = 1;
+
+               /* wait for a RELEASE so that sufficient time has passed
+                  for the inband audio to be heard */
+               if (c->progressmask & PRI_PROG_INBAND_AVAILABLE)
+                       break;
+
               /* Return such an event */
               pri->ev.e = PRI_EVENT_HANGUP_REQ;
               pri->ev.hangup.channel = c->channelno | (c->ds1no << 8) |
(c->ds1explicit << 16); 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-20-08 08:46  stevedavies    Note Added: 0089006                          
======================================================================